Added Metadata for Roles (#2450)

* Added Metadata for Roles

* Added Metadata to Put Role Request

Author: gmoskovicz

src/Nest/XPack/Security/Role/GetRole/Role.cs

@@ -15,5 +15,7 @@ public class XPackRole
 		[JsonProperty("indices")]
 		public IReadOnlyCollection<IIndicesPrivileges> Indices { get; private set; } = EmptyReadOnly<IIndicesPrivileges>.Collection;
 
+		[JsonProperty("metadata")]
+		public IReadOnlyDictionary<string, object> Metadata { get; internal set; } = EmptyReadOnly<string, object>.Dictionary;
 	}
 }

src/Nest/XPack/Security/Role/PutRole/PutRoleRequest.cs

@@ -15,6 +15,9 @@ public partial interface IPutRoleRequest
 		[JsonProperty("indices")]
 		IEnumerable<IIndicesPrivileges> Indices { get; set; }
 
+		[JsonProperty("metadata")]
+		IDictionary<string, object> Metadata { get; set; }
+
 	}
 
 	public partial class PutRoleRequest
@@ -24,6 +27,8 @@ public partial class PutRoleRequest
 		public IEnumerable<string> RunAs { get; set; }
 
 		public IEnumerable<IIndicesPrivileges> Indices { get; set; }
+
+		public IDictionary<string, object> Metadata { get; set; }
 	}
 
 	[DescriptorFor("XpackSecurityPutRole")]
@@ -32,6 +37,7 @@ public partial class PutRoleDescriptor
 		IEnumerable<string> IPutRoleRequest.Cluster { get; set; }
 		IEnumerable<string> IPutRoleRequest.RunAs { get; set; }
 		IEnumerable<IIndicesPrivileges> IPutRoleRequest.Indices { get; set; }
+		IDictionary<string, object> IPutRoleRequest.Metadata { get; set; }
 
 		public PutRoleDescriptor Cluster(IEnumerable<string> clusters) => Assign(a => a.Cluster = clusters);
 		public PutRoleDescriptor Cluster(params string[] clusters) => Assign(a => a.Cluster = clusters);
@@ -45,5 +51,10 @@ public partial class PutRoleDescriptor
 		public PutRoleDescriptor Indices(Func<IndicesPrivilegesDescriptor, IPromise<IList<IIndicesPrivileges>>> selector) =>
 			Assign(a => a.Indices = selector?.Invoke(new IndicesPrivilegesDescriptor())?.Value);
 
+
+		public PutRoleDescriptor Metadata(IDictionary<string, object> metadata) => Assign(a => a.Metadata = metadata);
+		public PutRoleDescriptor Metadata(Func<FluentDictionary<string, object>, IDictionary<string, object>> selector) =>
+			Assign(a => a.Metadata = selector?.Invoke(new FluentDictionary<string, object>()));
+
 	}
 }

src/Tests/XPack/Security/Role/PutRole/PutRoleApiTests.cs

@@ -45,6 +45,13 @@ protected override LazyResponses ClientUsage() => Calls(
 					field_security = new { grant = new [] { "name", "description" } },
 					query = new { match_all = new {} }
 				}
+			},
+			metadata = new []
+			{
+				new
+				{
+					_internal = true
+				}
 			}
 		};
 
@@ -64,6 +71,10 @@ protected override LazyResponses ClientUsage() => Calls(
 					Privileges = new [] { "all" },
 					Query = new MatchAllQuery()
 				}
+			},
+			Metadata = new Dictionary<string, object>()
+			{
+				{ "_internal", true }
 			}
 		};
 
@@ -84,7 +95,8 @@ protected override LazyResponses ClientUsage() => Calls(
 					.Privileges("all")
 					.Query(q => q.MatchAll())
 				)
-			);
+			)
+			.Metadata( m => m.Add("_internal", true));
 
 		protected override void ExpectResponse(IPutRoleResponse response)
 		{