Convert NotImplementedException to NotSupportedException

russcam · russcam · commit 6db94d6e60c7 · 2016-12-06T18:45:20.000+11:00
Semantically correct in these cases and means they do not get flagged as TODOs
diff --git a/src/Nest/Aggregations/Bucket/Terms/TermsIncludeExcludeJsonConverter.cs b/src/Nest/Aggregations/Bucket/Terms/TermsIncludeExcludeJsonConverter.cs
@@ -11,12 +11,12 @@ internal class TermsIncludeExcludeJsonConverter : JsonConverter
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			var termsIncludeExclude = value as TermsIncludeExclude;
+			var termsIncludeExclude = (TermsIncludeExclude)value;
 
 			if (termsIncludeExclude.Values != null)
 			{
diff --git a/src/Nest/Analysis/Analyzers/AnalyzerJsonConverter.cs b/src/Nest/Analysis/Analyzers/AnalyzerJsonConverter.cs
@@ -37,7 +37,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 	}
 }
diff --git a/src/Nest/Analysis/CharFilters/CharFilterJsonConverter.cs b/src/Nest/Analysis/CharFilters/CharFilterJsonConverter.cs
@@ -29,7 +29,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 	}
 }
diff --git a/src/Nest/Analysis/TokenFilters/TokenFilterJsonConverter.cs b/src/Nest/Analysis/TokenFilters/TokenFilterJsonConverter.cs
@@ -60,7 +60,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 	}
 }
diff --git a/src/Nest/Analysis/Tokenizers/TokenizerJsonConverter.cs b/src/Nest/Analysis/Tokenizers/TokenizerJsonConverter.cs
@@ -34,7 +34,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 	}
 }
diff --git a/src/Nest/CommonAbstractions/Fields/FieldValuesJsonConverter.cs b/src/Nest/CommonAbstractions/Fields/FieldValuesJsonConverter.cs
@@ -14,7 +14,7 @@ internal class FieldValuesJsonConverter : JsonConverter
 
 		public override bool CanConvert(Type objectType)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
diff --git a/src/Nest/CommonAbstractions/SerializationBehavior/GenericJsonConverters/JsonConverterBase.cs b/src/Nest/CommonAbstractions/SerializationBehavior/GenericJsonConverters/JsonConverterBase.cs
@@ -20,8 +20,8 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 
 	}
-}
+}
diff --git a/src/Nest/Document/Multiple/MultiGet/Request/MultiGetRequestJsonConverter.cs b/src/Nest/Document/Multiple/MultiGet/Request/MultiGetRequestJsonConverter.cs
@@ -43,8 +43,7 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
-
 	}
 }
diff --git a/src/Nest/IndexModules/Similarity/SimilarityJsonConverter.cs b/src/Nest/IndexModules/Similarity/SimilarityJsonConverter.cs
@@ -29,7 +29,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 	}
 }
diff --git a/src/Nest/Indices/Monitoring/IndicesShardStores/ShardStoreJsonConverter.cs b/src/Nest/Indices/Monitoring/IndicesShardStores/ShardStoreJsonConverter.cs
@@ -13,7 +13,7 @@ internal class ShardStoreJsonConverter : JsonConverter
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
diff --git a/src/Nest/Indices/StatusManagement/Upgrade/UpgradeStatus/UpgradeStatusResponseJsonConverter.cs b/src/Nest/Indices/StatusManagement/Upgrade/UpgradeStatus/UpgradeStatusResponseJsonConverter.cs
@@ -66,7 +66,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 	}
 }
diff --git a/src/Nest/Modules/SnapshotAndRestore/Repositories/CreateRepository/CreateRepositoryJsonConverter.cs b/src/Nest/Modules/SnapshotAndRestore/Repositories/CreateRepository/CreateRepositoryJsonConverter.cs
@@ -11,7 +11,7 @@ internal class CreateRepositoryJsonConverter : JsonConverter
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
@@ -20,4 +20,4 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
 			serializer.Serialize(writer, v.Repository);
 		}
 	}
-}
+}
diff --git a/src/Nest/QueryDsl/Abstractions/Container/QueryContainerJsonConverter.cs b/src/Nest/QueryDsl/Abstractions/Container/QueryContainerJsonConverter.cs
@@ -66,7 +66,7 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 
 		public override bool CanConvert(Type objectType) => true;
diff --git a/src/Nest/Search/MultiSearch/MultiSearchTemplate/MultiSearchTemplateJsonConverter.cs b/src/Nest/Search/MultiSearch/MultiSearchTemplate/MultiSearchTemplateJsonConverter.cs
@@ -16,12 +16,12 @@ internal class MultiSearchTemplateJsonConverter : JsonConverter
 
 		public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)
 		{
-			throw new NotImplementedException();
+			throw new NotSupportedException();
 		}
 
 		public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)
 		{
-			var request = value as IMultiSearchTemplateRequest;
+			var request = (IMultiSearchTemplateRequest)value;
 			if (request == null) return;
 			var settings = serializer.GetConnectionSettings();
 			var elasticsearchSerializer = settings.Serializer;

Original file line number	Diff line number	Diff line change
`@@ -11,12 +11,12 @@ internal class TermsIncludeExcludeJsonConverter : JsonConverter`
`11`	`11`
`12`	`12`	`public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)`
`13`	`13`	`{`
`14`		`- throw new NotImplementedException();`
	`14`	`+ throw new NotSupportedException();`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)`
`18`	`18`	`{`
`19`		`- var termsIncludeExclude = value as TermsIncludeExclude;`
	`19`	`+ var termsIncludeExclude = (TermsIncludeExclude)value;`
`20`	`20`
`21`	`21`	`if (termsIncludeExclude.Values != null)`
`22`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist`
`37`	`37`
`38`	`38`	`public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)`
`39`	`39`	`{`
`40`		`- throw new NotImplementedException();`
	`40`	`+ throw new NotSupportedException();`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist`
`29`	`29`
`30`	`30`	`public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)`
`31`	`31`	`{`
`32`		`- throw new NotImplementedException();`
	`32`	`+ throw new NotSupportedException();`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist`
`60`	`60`
`61`	`61`	`public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)`
`62`	`62`	`{`
`63`		`- throw new NotImplementedException();`
	`63`	`+ throw new NotSupportedException();`
`64`	`64`	`}`
`65`	`65`	`}`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist`
`34`	`34`
`35`	`35`	`public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)`
`36`	`36`	`{`
`37`		`- throw new NotImplementedException();`
	`37`	`+ throw new NotSupportedException();`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ internal class FieldValuesJsonConverter : JsonConverter`
`14`	`14`
`15`	`15`	`public override bool CanConvert(Type objectType)`
`16`	`16`	`{`
`17`		`- throw new NotImplementedException();`
	`17`	`+ throw new NotSupportedException();`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)`
Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,8 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s`
`20`	`20`
`21`	`21`	`public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)`
`22`	`22`	`{`
`23`		`- throw new NotImplementedException();`
	`23`	`+ throw new NotSupportedException();`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`}`
`27`		`-}`
	`27`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,7 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s`
`43`	`43`
`44`	`44`	`public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)`
`45`	`45`	`{`
`46`		`- throw new NotImplementedException();`
	`46`	`+ throw new NotSupportedException();`
`47`	`47`	`}`
`48`		`-`
`49`	`48`	`}`
`50`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ internal class ShardStoreJsonConverter : JsonConverter`
`13`	`13`
`14`	`14`	`public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer)`
`15`	`15`	`{`
`16`		`- throw new NotImplementedException();`
	`16`	`+ throw new NotSupportedException();`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)`