Skip to content

Conversation

@simitt
Copy link
Contributor

@simitt simitt commented Jul 6, 2018

  • Remove the auto generated fields listing, and explain how users can
    fetch the APM template instead.
  • Add a separate RUM section and split up sourcemap docs according to
    the existing structure. Use RUM instead of frontend.
  • Introduce a new part how to explore data in ES and move everything
    related.
  • This leads to only having a general overview of Event Types left on
    top level, for easier high level understanding of APM Events.

Builds on top of elastic/docs#395

implements #1083

High level overview:

screen shot 2018-07-06 at 15 28 27

Changed Event Types

screen shot 2018-07-06 at 15 28 39

screen shot 2018-07-06 at 15 28 46

RUM w. Source Mapping

screen shot 2018-07-06 at 15 28 58

screen shot 2018-07-06 at 15 29 05

Exploring data in ES

screen shot 2018-07-06 at 15 29 24
screen shot 2018-07-06 at 15 29 35

@simitt simitt requested a review from dedemorton July 6, 2018 13:32
For getting an overview of existing indices you can run:
["source","sh"]
------------------------------------------------------------
GET _cat/indices
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe filtering apm would be even more useful GET _cat/indices/apm*?


["source","sh"]
------------------------------------------------------------
GET _cat/templates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with indices GET _cat/templates/apm*? Just a thought


[partintro]
--
By default Elastic APM data are stored in different index types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different index types -> different indices

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "data is stored"

--
By default Elastic APM data are stored in different index types.

Indices storing monitored data are built in the format of `apm-[version]-[type]-[date]` by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monitored data sounds odd but I'm not sure what else to call the onboarding docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you need to say "monitored data" here. Maybe just say something like:

The indices are named `apm-[version]-[type]-[date]` by default.

Then give an example. The way it's worded right now, sounds like the indices themselves use some kind of special format, but really it's jut the index name that uses the format.

@dedemorton dedemorton mentioned this pull request Jul 6, 2018
3 tasks
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the level of detail that you've added here. The content needs a technical edit. Rather than adding a bunch of comments to this review, though, I think the content should be edited in a separate pass after the PR is reviewed for technical accuracy and merged. I've added the PR to the meta issue that I created here to track edits: #1090


This format makes it easy to query for all Elastic APM data at once by using `apm-*`.

It also allows for querying documents that have been collected with a specific APM Server version, e.g. `apm-6.3.0*`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you should either remove the e.g. apm-6.3.0* bit or use a variable pulling the current version

Some of the key attributes of an error are described in more detail:
Errors can either relate to monitored <<transactions, transactions>>
or be monitored stand alone,
depending on how your APM agents are set up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading this, i guess someone will want to know how to set up an agent to relate errors and transactions...

[partintro]
--
By default Elastic APM data are stored in different indices,
in the format of `apm-[version]-[type]-[date]`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a line here saying that type is one of error, transaction, etc.; or a link to the event types section

Spans are monitored as parts of <<transactions, transactions>>.
They are stored in their separate indices `apm-[version]-span-[date]` though.

Spans at least collect information about when the code path execution started,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean with "at least"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah got it, never mind

@jalvz
Copy link
Contributor

jalvz commented Jul 9, 2018

Forgot to mention: this could be split in 2 commits (or prs, it doesn't matter):
One for the things that make sense to backport (eg. removing exported fields), and other for the things that don't (RUM), wdyt?

simitt added 2 commits July 9, 2018 10:32
* Remove the auto generated fields listing, and explain how users can
fetch the APM template instead.
* Add a separate RUM section and split up sourcemap docs according to
the existing structure.
* Introduce a new part how to explore data in ES and move everything
related.
* This leads to only having a general overview of Event Types left on
top level, for easier high level understanding of APM Events.
@simitt
Copy link
Contributor Author

simitt commented Jul 9, 2018

I suggest to backport to 6.x and 6.3. In 6.3 we already have experimental RUM support, so I would experimental to those section.
WDYT @jalvz

@simitt simitt force-pushed the docs-cleanup-fields branch from 4db2b48 to 7de27b1 Compare July 9, 2018 09:59
@simitt
Copy link
Contributor Author

simitt commented Jul 9, 2018

After rebasing onto master this is the index overview:

screen shot 2018-07-09 at 11 59 45

@simitt
Copy link
Contributor Author

simitt commented Jul 9, 2018

@roncohen I added the fields section again as just discussed, please approve if you're fine with.

screen shot 2018-07-09 at 16 56 52

@simitt simitt merged commit c8ced67 into elastic:master Jul 9, 2018
simitt added a commit to simitt/apm-server that referenced this pull request Jul 9, 2018
* Add a separate RUM section and split up sourcemap docs according to
the existing structure.
* Introduce a new part how to explore data in ES and move everything
related, except for the fields section.
* Keep Event Types on top level, but move ES examples to ES section
simitt added a commit to simitt/apm-server that referenced this pull request Jul 9, 2018
* Add a separate RUM section and split up sourcemap docs according to
the existing structure.
* Introduce a new part how to explore data in ES and move everything
related, except for the fields section.
* Keep Event Types on top level, but move ES examples to ES section
simitt added a commit that referenced this pull request Jul 9, 2018
* Add a separate RUM section and split up sourcemap docs according to
the existing structure.
* Introduce a new part how to explore data in ES and move everything
related, except for the fields section.
* Keep Event Types on top level, but move ES examples to ES section
simitt added a commit that referenced this pull request Jul 10, 2018
* Add a separate RUM section and split up sourcemap docs according to
the existing structure.
* Introduce a new part how to explore data in ES and move everything
related, except for the fields section.
* Keep Event Types on top level, but move ES examples to ES section
@simitt simitt deleted the docs-cleanup-fields branch July 10, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants