Skip to content

Commit 07844d0

Browse files
committed
fix: Export ParseDurationWithDay function
Relates #1013. Export the ParseDurationWithDay function for external use. Signed-off-by: Lindsey Cheng <[email protected]>
1 parent 11bffbc commit 07844d0

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

common/validator.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ func getErrorMessage(e validator.FieldError) string {
138138
func ValidateDuration(fl validator.FieldLevel) bool {
139139
durationStr := fl.Field().String()
140140

141-
valid, duration := parseDurationWithDay(durationStr)
141+
valid, duration := ParseDurationWithDay(durationStr)
142142
if !valid {
143143
return false
144144
}
@@ -150,7 +150,7 @@ func ValidateDuration(fl validator.FieldLevel) bool {
150150
if len(params) > 0 {
151151
// Check if minimum value is defined from the tag param
152152
if params[0] != "" {
153-
valid, minDuration := parseDurationWithDay(params[0])
153+
valid, minDuration := ParseDurationWithDay(params[0])
154154
if !valid {
155155
return false
156156
}
@@ -163,7 +163,7 @@ func ValidateDuration(fl validator.FieldLevel) bool {
163163
if len(params) > 1 {
164164
// Check if maximum value is defined from the tag param
165165
if params[1] != "" {
166-
valid, maxDuration := parseDurationWithDay(params[1])
166+
valid, maxDuration := ParseDurationWithDay(params[1])
167167
if !valid {
168168
return false
169169
}
@@ -178,9 +178,9 @@ func ValidateDuration(fl validator.FieldLevel) bool {
178178
return true
179179
}
180180

181-
// parseDurationWithDay extends duration string parsing to support the "d" (day) unit.
181+
// ParseDurationWithDay extends duration string parsing to support the "d" (day) unit.
182182
// It returns a boolean indicating whether the string is valid, along with the corresponding Duration value.
183-
func parseDurationWithDay(durationStr string) (bool, time.Duration) {
183+
func ParseDurationWithDay(durationStr string) (bool, time.Duration) {
184184
// Duration string should not be empty
185185
if durationStr == "" {
186186
return false, time.Duration(0)

common/validator_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ func TestValidateDuration_WithMinMax(t *testing.T) {
142142
}
143143
}
144144

145-
// TestParseDurationWithDay tests the parseDurationWithDay function
145+
// TestParseDurationWithDay tests the ParseDurationWithDay function
146146
func TestParseDurationWithDay(t *testing.T) {
147147
durStr1 := "10h30m"
148148
expectedDur1, err := time.ParseDuration(durStr1)
@@ -193,7 +193,7 @@ func TestParseDurationWithDay(t *testing.T) {
193193

194194
for _, tt := range tests {
195195
t.Run(tt.name, func(t *testing.T) {
196-
result, duration := parseDurationWithDay(tt.durString)
196+
result, duration := ParseDurationWithDay(tt.durString)
197197
require.Equal(t, tt.expectedResult, result)
198198
if tt.expectedResult {
199199
require.Equal(t, tt.expectedDuration, duration)

0 commit comments

Comments
 (0)