Skip to content

Conversation

@elkir
Copy link
Contributor

@elkir elkir commented Nov 19, 2025

Description

Small control flow rectification

What problem does this change solve?

saves doubling up tensors and autograd on the GPU

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@elkir elkir added models ATS Approval Not Needed No approval needed by ATS labels Nov 19, 2025
@github-actions github-actions bot added the bug Something isn't working label Nov 19, 2025
@HCookie HCookie moved this to Reviewers needed in Anemoi-dev Nov 19, 2025
Copy link
Contributor

@OpheliaMiralles OpheliaMiralles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's better! I admit this was not a verxy efficient implementation

@github-project-automation github-project-automation bot moved this from Reviewers needed to For merging in Anemoi-dev Nov 19, 2025
Copy link
Member

@HCookie HCookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, and thanks to @OpheliaMiralles for the review

@HCookie HCookie merged commit 66b40e0 into main Nov 19, 2025
13 checks passed
@HCookie HCookie deleted the fix-small-pytorch-boxcox-inefficiency branch November 19, 2025 14:13
@github-project-automation github-project-automation bot moved this from For merging to Done in Anemoi-dev Nov 19, 2025
@DeployDuck DeployDuck mentioned this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATS Approval Not Needed No approval needed by ATS bug Something isn't working models

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants