feat(models): add configurable residual connections in enc-proc-dec #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCookie
reviewed
Nov 19, 2025
Closed
Co-authored-by: Harrison Cook <[email protected]>
anaprietonem
approved these changes
Nov 20, 2025
Contributor
There was a problem hiding this comment.
thanks Mario for addressing the comments from my side it's okey, let's see if @HCookie has any other remaining comments and then merge! almost there🚀
HCookie
previously approved these changes
Nov 20, 2025
github-project-automation
bot
moved this from Under Review
to For merging
in Anemoi-dev
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to PR #451 . The branch has been moved to anemoi-core (so we can now run integration tests), and rebased with main.
BaseResidualConnection. It currently supports 3 options:SkipConnection,TruncatedConnection, andNoConnection.SparseProjectorclass which handles the projection logic. This class could be used in the future for the multi-scale loss or other use cases.What problem does this change solve?
Encapsulation of residual connection functionality.
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-training--670.org.readthedocs.build/en/670/
📚 Documentation preview 📚: https://anemoi-graphs--670.org.readthedocs.build/en/670/
📚 Documentation preview 📚: https://anemoi-models--670.org.readthedocs.build/en/670/