plugin: fix notebook stubs
#12003
Merged
plugin: fix notebook stubs
#12003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes some stubs from the `notebook` API which prevented extensions from activating and producing errors. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
added
vscode
Contributor
|
@rschnekenbu : Could you have a look? |
rschnekenbu
approved these changes
Dec 19, 2022
Contributor
rschnekenbu
left a comment
rschnekenbu
left a comment
There was a problem hiding this comment.
Looks good to me!
I indeed get same issues during activation on master, and no errors are shown when running with this change.
JonasHelming
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #11993 (comment).
The pull-request fixes some stubs from the
notebookAPI which prevented extensions from activating and producing errors.How to test
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]