Fix: use IWorkbenchWindow/IWorkbenchPage, add copyright headers

aloowood · aloowood · commit c197fd610928 · 2025-08-17T11:22:28.000+03:00
diff --git a/tests/org.eclipse.ui.tests.dnd/.project b/tests/org.eclipse.ui.tests.dnd/.project
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DetachedDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DetachedDropTarget.java
@@ -11,6 +11,7 @@
  * Contributors:
  *     IBM Corporation - initial API and implementation
  *******************************************************************************/
+
 package org.eclipse.ui.tests.dnd;
 
 import org.eclipse.swt.graphics.Point;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DragDropPerspectiveFactory.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DragDropPerspectiveFactory.java
@@ -5,9 +5,6 @@
 import org.eclipse.ui.IPerspectiveFactory;
 import org.eclipse.ui.IPlaceholderFolderLayout;
 
-/**
- * @since 3.0
- */
 public class DragDropPerspectiveFactory implements IPerspectiveFactory {
 
 	// Id's needed by the 'Detached Window' Drag / Drop tests
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DragOperations.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DragOperations.java
@@ -11,9 +11,6 @@
 import org.eclipse.ui.IWorkbenchPartReference;
 import org.junit.Assert;
 
-/**
- * @since 3.0
- */
 public class DragOperations {
 
 	/**
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DragTest.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DragTest.java
@@ -1,3 +1,14 @@
+/*******************************************************************************
+ * Copyright (c) 2025 Ali Muhsin KÖKSAL.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License 2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * Contributors:
+ *     Ali Muhsin KÖKSAL - initial API and implementation
+ *******************************************************************************/
+
 package org.eclipse.ui.tests.dnd;
 
 import org.eclipse.core.resources.IFile;
@@ -6,9 +17,10 @@
 import org.eclipse.swt.widgets.Display;
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.IEditorPart;
+import org.eclipse.ui.IWorkbenchPage;
+import org.eclipse.ui.IWorkbenchWindow;
 import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.internal.WorkbenchPage;
-import org.eclipse.ui.internal.WorkbenchWindow;
 import org.eclipse.ui.part.FileEditorInput;
 import org.eclipse.ui.tests.api.MockEditorPart;
 import org.eclipse.ui.tests.harness.util.FileUtil;
@@ -26,8 +38,8 @@ public class DragTest {
 
     IEditorPart editor1, editor2, editor3;
 
-    static WorkbenchWindow window;
-    static WorkbenchPage page;
+    static IWorkbenchWindow window;
+    static IWorkbenchPage page;
 
     public DragTest(TestDragSource dragSource, TestDropLocation dropTarget) {
         this.dragSource = dragSource;
@@ -37,8 +49,8 @@ public DragTest(TestDragSource dragSource, TestDropLocation dropTarget) {
     @AfterEach
     public void doSetUp() throws Exception {
         if (window == null) {
-            window = (WorkbenchWindow) PlatformUI.getWorkbench();
-            page = (WorkbenchPage) window.getActivePage();
+            window = (IWorkbenchWindow) PlatformUI.getWorkbench();
+            page = (IWorkbenchPage) window.getActivePage();
 
             project = FileUtil.createProject("DragTest");
             file1 = FileUtil.createFile("DragTest1.txt", project);
@@ -86,10 +98,10 @@ public void stallTest() {
             }
         }
     }
-
-    @Test
+    
+	@Test
     public void performTest() throws Throwable {
-        dragSource.setPage(page);
+        dragSource.setPage((WorkbenchPage) page);
         dragSource.drag(dropTarget);
     }
 }
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DragTestSuite.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/DragTestSuite.java
@@ -1,3 +1,14 @@
+/*******************************************************************************
+ * Copyright (c) 2025 Ali Muhsin KÖKSAL.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License 2.0
+ * which accompanies this distribution, and is available at
+ * https://www.eclipse.org/legal/epl-2.0/
+ *
+ * Contributors:
+ *     Ali Muhsin KÖKSAL - initial API and implementation
+ *******************************************************************************/
+
 package org.eclipse.ui.tests.dnd;
 
 import org.eclipse.swt.SWT;
@@ -189,7 +200,7 @@ private void addAllCombinations(TestDragSource dragSource,
 				continue;
 			}
 
-			DragTest newTest = new DragTest(dragSource, dropTarget);
+			new DragTest(dragSource, dropTarget);
 		}
 	}
 
@@ -199,7 +210,7 @@ private void addAllCombinationsDetached(TestDragSource dragSource,
 
 		if (isDetachingSupported) {
 			for (TestDropLocation dropTarget : dropTargets) {
-				DragTest newTest = new DetachedWindowDragTest(dragSource, dropTarget);
+				new DetachedWindowDragTest(dragSource, dropTarget);
 			}
 		}
 	}
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorAreaDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorAreaDropTarget.java
@@ -2,9 +2,6 @@
 
 import org.eclipse.swt.graphics.Point;
 
-/**
- * @since 3.0
- */
 public class EditorAreaDropTarget extends WorkbenchWindowDropTarget {
 	int side;
 
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorDragSource.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorDragSource.java
@@ -2,9 +2,6 @@
 
 import org.eclipse.ui.IEditorPart;
 
-/**
- * @since 3.0
- */
 public class EditorDragSource extends TestDragSource {
 
 	int editorIdx;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorDropTarget.java
@@ -4,9 +4,6 @@
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.IEditorPart;
 
-/**
- * @since 3.0
- */
 public class EditorDropTarget extends WorkbenchWindowDropTarget {
 
 	int editorIdx;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorTabDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorTabDropTarget.java
@@ -5,9 +5,6 @@
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.IEditorPart;
 
-/**
- * @since 3.0
- */
 public class EditorTabDropTarget extends WorkbenchWindowDropTarget {
 
 	int editorIdx;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorTitleDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/EditorTitleDropTarget.java
@@ -5,9 +5,6 @@
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.ui.IEditorPart;
 
-/**
- * @since 3.0
- */
 public class EditorTitleDropTarget extends WorkbenchWindowDropTarget {
 
 	int editorIdx;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/StandaloneViewPerspective.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/StandaloneViewPerspective.java
@@ -3,10 +3,6 @@
 import org.eclipse.ui.IPageLayout;
 import org.eclipse.ui.IPerspectiveFactory;
 
-/**
- *
- * @since 3.1.1
- */
 public class StandaloneViewPerspective implements IPerspectiveFactory {
 
 	public static final String OUTLINE_ID = IPageLayout.ID_OUTLINE;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/TestDragSource.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/TestDragSource.java
@@ -5,9 +5,6 @@
 import org.eclipse.ui.internal.WorkbenchPage;
 import org.eclipse.ui.internal.WorkbenchWindow;
 
-/**
- * @since 3.0
- */
 public abstract class TestDragSource implements IWorkbenchWindowProvider {
 	private WorkbenchPage page;
 
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/TestDropLocation.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/TestDropLocation.java
@@ -8,7 +8,6 @@
  * this interface to force any dragged object to be dropped at a particular
  * location.
  *
- * @since 3.0
  */
 public interface TestDropLocation {
 
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/ViewDragSource.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/ViewDragSource.java
@@ -7,9 +7,6 @@
 import org.eclipse.ui.views.IViewDescriptor;
 import org.junit.Assert;
 
-/**
- * @since 3.0
- */
 public class ViewDragSource extends TestDragSource {
 
 	String targetPart;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/ViewDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/ViewDropTarget.java
@@ -6,9 +6,6 @@
 import org.eclipse.ui.internal.WorkbenchPlugin;
 import org.eclipse.ui.views.IViewDescriptor;
 
-/**
- * @since 3.0
- */
 public class ViewDropTarget extends WorkbenchWindowDropTarget {
 
 	String targetPart;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/ViewTabDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/ViewTabDropTarget.java
@@ -15,7 +15,6 @@
  * right now since the current tests only use the tabs-on-top drop
  * location).
  *
- * @since 3.0
  */
 public class ViewTabDropTarget extends WorkbenchWindowDropTarget {
 
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/ViewTitleDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/ViewTitleDropTarget.java
@@ -15,7 +15,6 @@
  * right now since the current tests only use the tabs-on-top drop
  * location).
  *
- * @since 3.0
  */
 public class ViewTitleDropTarget extends WorkbenchWindowDropTarget {
 
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/WindowDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/WindowDropTarget.java
@@ -5,9 +5,6 @@
 import org.eclipse.swt.graphics.Rectangle;
 import org.eclipse.swt.widgets.Shell;
 
-/**
- * @since 3.0
- */
 public class WindowDropTarget extends WorkbenchWindowDropTarget {
 
 	private final int side;
diff --git a/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/WorkbenchWindowDropTarget.java b/tests/org.eclipse.ui.tests.dnd/src/org/eclipse/ui/tests/dnd/WorkbenchWindowDropTarget.java
@@ -5,9 +5,6 @@
 import org.eclipse.ui.IWorkbenchWindow;
 import org.eclipse.ui.internal.WorkbenchPage;
 
-/**
- * @since 3.0
- */
 public abstract class WorkbenchWindowDropTarget implements TestDropLocation {
 
 	private final IWorkbenchWindowProvider window;

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,14 @@`
	`1`	`+/*******************************************************************************`
	`2`	`+ * Copyright (c) 2025 Ali Muhsin KÖKSAL.`
	`3`	`+ * All rights reserved. This program and the accompanying materials`
	`4`	`+ * are made available under the terms of the Eclipse Public License 2.0`
	`5`	`+ * which accompanies this distribution, and is available at`
	`6`	`+ * https://www.eclipse.org/legal/epl-2.0/`
	`7`	`+ *`
	`8`	`+ * Contributors:`
	`9`	`+ * Ali Muhsin KÖKSAL - initial API and implementation`
	`10`	`+ *******************************************************************************/`
	`11`	`+`
`1`	`12`	`package org.eclipse.ui.tests.dnd;`
`2`	`13`
`3`	`14`	`import org.eclipse.swt.SWT;`
`@@ -189,7 +200,7 @@ private void addAllCombinations(TestDragSource dragSource,`
`189`	`200`	`continue;`
`190`	`201`	`}`
`191`	`202`
`192`		`- DragTest newTest = new DragTest(dragSource, dropTarget);`
	`203`	`+ new DragTest(dragSource, dropTarget);`
`193`	`204`	`}`
`194`	`205`	`}`
`195`	`206`
`@@ -199,7 +210,7 @@ private void addAllCombinationsDetached(TestDragSource dragSource,`
`199`	`210`
`200`	`211`	`if (isDetachingSupported) {`
`201`	`212`	`for (TestDropLocation dropTarget : dropTargets) {`
`202`		`- DragTest newTest = new DetachedWindowDragTest(dragSource, dropTarget);`
	`213`	`+ new DetachedWindowDragTest(dragSource, dropTarget);`
`203`	`214`	`}`
`204`	`215`	`}`
`205`	`216`	`}`