4.31 I-Build: I20240114-1800 - BUILD FAILED

[MohananRahul]

See https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/91/console

[jukzi]

regression from eclipse-platform/eclipse.platform.swt#973

00:07:42  [INFO] --- antrun:3.1.0:run (collect-java-sources) @ org.eclipse.swt.gtk.linux.x86_64 ---
00:07:42  [INFO] Executing tasks
00:07:42  [INFO]      [exec] build-scripts/CollectSources.java:35: error: illegal start of expression
00:07:42  [INFO]      [exec] 		private static ScriptEnvironment read(String[] args) {
00:07:42  [INFO]      [exec] 		^

@HannesWell

[HannesWell]

That's unexpected, because in general it works to launch the Java script, as one can see at the SWT master branch build.
But I have seen similar errors in early versions of the PR when the java executable used by the Jenkins executor by default was a Java-11 one. But this script requires Java-17, mainly due to the use of records (but maybe also other library calls).

I can investigate this in detail this evening, unless somebody else has fixed it in the meantime. But my current guess is that the Maven build is launched with an explicit java exe and not the default one on the system, which I assume is still Java-11.
Maybe it is sufficient to add a tools section to the build stage that installs java-17.

[HannesWell]

After applying #1727 the newly triggered I-build failed with:

19:06:34  [ssh-agent] Using credentials eclipse-releng-bot (GitHub bot (SSH))
19:06:34  [ssh-agent] Looking for ssh-agent implementation...
19:06:35  [ssh-agent] FATAL: Could not find a suitable ssh-agent provider
19:06:35  [ssh-agent] Diagnostic report

[HannesWell]

I replayed the I build with and without the new tools section echoing the value of PATH and with

  tools {
      jdk 'openjdk-jdk17-latest'
      maven 'apache-maven-latest'
  }

PATH is

/opt/tools/java/openjdk/jdk-17/latest/bin:
/opt/tools/apache-maven/latest/bin:
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

and without PATH is just

/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

So the tools are prepended as expected, but somehow the sshagent step does not like the newer java version (I assume maven is not relevant here)?
If the tools are removed again, the Setup intial configuration works...

[akurtakov]

Is the path really multiline ?

[HannesWell]

Is the path really multiline ?

No it is linear. I just split it for better comparability.

I now did some replays (with failure mails disabled to not spam everybody) and it looks like that the

tools {
    maven 'apache-maven-latest'
}

Breaks the build, at least the replay https://ci.eclipse.org/releng/job/Builds/job/I-build-4.31/95/console makes me be believe it.

[akurtakov]

If that's the case define just the jdk tool.

[HannesWell]

If that's the case define just the jdk tool.

Tried that with I-build-4.31#97. Fingers crossed.