Skip to content

Commit edfb9a5

Browse files
authored
Merge pull request #3806 from boegel/report_ignore_test_failure
report use of --ignore-test-failure in success message in output
2 parents 25b5ade + 0ffd0c9 commit edfb9a5

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

easybuild/main.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,10 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None):
527527

528528
correct_builds_cnt = len([ec_res for (_, ec_res) in ecs_with_res if ec_res.get('success', False)])
529529
overall_success = correct_builds_cnt == len(ordered_ecs)
530-
success_msg = "Build succeeded for %s out of %s" % (correct_builds_cnt, len(ordered_ecs))
530+
success_msg = "Build succeeded "
531+
if build_option('ignore_test_failure'):
532+
success_msg += "(with --ignore-test-failure) "
533+
success_msg += "for %s out of %s" % (correct_builds_cnt, len(ordered_ecs))
531534

532535
repo = init_repository(get_repository(), get_repositorypath())
533536
repo.cleanup()

test/framework/toy_build.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3491,6 +3491,14 @@ def test_toy_build_sanity_check_linked_libs(self):
34913491
self.test_toy_build(ec_file=test_ec, extra_args=args, force=False,
34923492
raise_error=True, verbose=False, verify=False)
34933493

3494+
def test_toy_ignore_test_failure(self):
3495+
"""Check whether use of --ignore-test-failure is mentioned in build output."""
3496+
args = ['--ignore-test-failure']
3497+
stdout, stderr = self.run_test_toy_build_with_output(extra_args=args, verify=False, testing=False)
3498+
3499+
self.assertTrue("Build succeeded (with --ignore-test-failure) for 1 out of 1" in stdout)
3500+
self.assertFalse(stderr)
3501+
34943502

34953503
def suite():
34963504
""" return all the tests in this file """

0 commit comments

Comments
 (0)