add custom easyblock to build & install ROCm components #3861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thyre
changed the title
Signed-off-by: Jan André Reuter <[email protected]>
boegel
changed the title
Member
|
@Thyre Seems like this should be a generic easyblock instead, since it's not specific to one single software package, but will cover a whole group? |
Collaborator
Author
Yeah, I agree. I wasn't really sure initially where to place it, so I left it there for now. I'll move it to the generic ones. As you've guessed, this can be used for most ROCm components. |
Signed-off-by: Jan André Reuter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)This is a draft EasyBlock supporting the build of ROCm components by unifying similar config options into one EasyBlock on top of CMakeMake.
A few things can be cleaned up, e.g. using
list_to_cmake_argof the CMakeMake EasyBlock, now that this has been integrated.ROCm components will slowly be added in EasyConfig PRs, with one example being easybuilders/easybuild-easyconfigs#23542, which can benefit significantly.