-
Notifications
You must be signed in to change notification settings - Fork 303
make LLVM easyblock aware of amdgcn_capabilities build option
#3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make LLVM easyblock aware of amdgcn_capabilities build option
#3824
Conversation
This allows building LLVM with AMD GPU support without requiring to adapt the LLVM EasyConfig beforehand. Deprecate 'amd_gfx_list', but still accept the value if the new build option is not set.
amdgcn_capabilitiesamdgcn_capabilities
Signed-off-by: Jan André Reuter <[email protected]>
|
LLVM 20.1.7 tests:
|
amdgcn_capabilitiesamdgcn_capabilities
|
@Crivella can you take a quick look at this PR in the next few weeks? Would be great to have this merged quickly after the corresponding framework PR (and for ROCm-LLVM). |
|
With Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 47 out of 47 (1 easyconfigs in total) |
|
With Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 3116981134 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Crivella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Going in, thanks @Thyre! |
amdgcn_capabilitiesamdgcn_capabilities build option
Requires:
amdgcn-capabilitiesconfiguration option andamdgcn_capabilitieseasyconfig parameter + related templates, similar tocuda-compute-capabilitieseasybuild-framework#4860This allows building LLVM with AMD GPU support without requiring to adapt the LLVM EasyConfig beforehand. Deprecate
amd_gfx_list, but still accept the value if the new build option is not set.