Skip to content

[Minor] Adding defaultValue to textarea #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[Minor] Adding defaultValue to textarea #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...c/app/components/examples/textarea/textarea-properties/textarea-properties.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,13 @@
and the value will be managed internally.
</td>
</tr>
<tr>
<td>defaultValue: string</td>
<td></td>
<td>
Default value given to the textarea when is uncontrolled and also maintains the uncontrolled behaviour.
</td>
</tr>
<tr>
<td>label: string</td>
<td></td>
Expand Down
6 changes: 6 additions & 0 deletions ...ite/src/app/pages/theme-builder/previews/textarea-preview/textarea-preview.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@
tabIndexValue="3"
>
</dxc-textarea>
<dxc-textarea
label="default value"
[pattern]="pattern"
defaultValue="Default"
>
</dxc-textarea>
</tbuilder-component-mode>
<tbuilder-component-mode text="Invalid">
<dxc-textarea label="Test" error="error"> </dxc-textarea>
Expand Down
2 changes: 2 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-textarea/dxc-textarea.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@ describe("DxcTextareaComponent", () => {
await render(DxcTextareaComponent, {
componentProperties: {
label: "Example label",
defaultValue: "test",
onChange: {
emit: onChange,
} as any,
Expand All @@ -406,6 +407,7 @@ describe("DxcTextareaComponent", () => {
const textarea = <HTMLInputElement>(
screen.getByLabelText("Example label (Optional)")
);
expect(screen.getByDisplayValue("test"));
textarea.focus();
expect(textarea).toHaveFocus();
fireEvent.click(textarea);
Expand Down
7 changes: 5 additions & 2 deletions projects/dxc-ngx-cdk/src/lib/dxc-textarea/dxc-textarea.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export class DxcTextareaComponent implements OnInit {

@Input()
value: string;

@Input()
defaultValue: string;

@Input()
id: string;
Expand Down Expand Up @@ -110,7 +113,7 @@ export class DxcTextareaComponent implements OnInit {
optional: false,
disabled: false,
helperText: "",
value: "",
value: undefined,
name: "",
label: "",
margin: "",
Expand Down Expand Up @@ -172,7 +175,7 @@ export class DxcTextareaComponent implements OnInit {

ngOnInit(): void {
if (this.value === undefined) {
this.value = "";
this.value = this.defaultValue ?? "";
this.controlled = false;
} else {
this.controlled = true;
Expand Down