Commit f864a39
Pick up the recent updates from the Facebook WDA repository (#87)
* Remove TableView scrolling integration tests
Summary: We have duplicated scrolling tests for regular tableViews and simple scrollviews. It was usefull to have them, but now testing scrolling on scrollviews covers both cases anyway and we will waste less time testing.
Reviewed By: antiarchit
Differential Revision: D6543548
fbshipit-source-id: 35e717c43208b8f138a706798d9aa8a9e34b302a
* Use fb_tapWithError in alert integration tests
Summary:
Some alert integration tests are flaky on our CI. I suspect this happens due to failing `tap` command, which might be failing to tap on animated view. This know XCTest issue.
Fortunately we have `fb_tapWithError` that handels are common pitfalls.
Reviewed By: antiarchit
Differential Revision: D6543616
fbshipit-source-id: f12ea7da67058253deff53fa980ebf2e55a93899
* Fix rotation integeation tests
Summary: Rather then depending on XCUITest information on orientation, we should test what is application perception
Reviewed By: antiarchit
Differential Revision: D6543511
fbshipit-source-id: 192e50d0202f96bd6119921c9353a72789b33ad4
* Kill testExtrasIconContent
Summary:
This test is super device/simulator specific, that was used to interate on visibility improvements.
Right now it does not bring much value anyway.
Reviewed By: antiarchit
Differential Revision: D6543627
fbshipit-source-id: ffbda3b0b5ecde6a632e88030e84fae5af614347
* Use Xcode 9.2 and iOS 11.2 on Travis
Summary: It is time to move on.
Reviewed By: antiarchit
Differential Revision: D6692223
fbshipit-source-id: 81913167551191b2f9e177ff1ead943f6fc25752
* Fix scrolling on big scroll offsets
Summary:
`XCUICoordinate` seems to have a bug that will return half of offset in case coordinate referance point goes off screen. I suspect this has something to do with retina displays.
Instead of using Apple's implementation of `screenPoint` I implemented our own.
Reviewed By: antiarchit
Differential Revision: D6702218
fbshipit-source-id: b01ef061732281cdf8c6707de38a11b6e31b9c28
* Run testInvisibleDescendantWithXPathQuery test on scroll page
Summary:
With all visibility changes tested pageindicator is no longer considered invisible. For the time being this is ok with us.
This diff uses different invisible elements to run same test of search for invisible elements
Reviewed By: antiarchit
Differential Revision: D6702252
fbshipit-source-id: a2bd5198d14f05cb1b33afe76a6b5bda7e34a847
* Do not run testSpringBoardIcons on iPads
Summary: This test was not intended to run on iPad, so we should turn it off so that we can make Travis green again :).
Reviewed By: antiarchit
Differential Revision: D6726707
fbshipit-source-id: db92f23b2dc755e7c1464069c04b1838717b8ff4
* Fix resolving XCUIApplication snapshots
Summary:
With new xcode it looks like, calling `query`, `resolve` on XCUIApplication will in some sense break it. Not sure exactly what goes wrong, but final result is that it's missing some children and description of that object is empty.
Instead we can use new API for fetching snapshots for debugging.
Reviewed By: lawrencelomax
Differential Revision: D6723102
fbshipit-source-id: a33d9caf03eef4450f3879996493493c2cb257b4
* Use visibleFrame to calculate scrolling vector
Summary:
Using views frame for calculating scroling vector might be buggy when application is doing tricky stuff with scolling views eg. nesting scrollview within scrollview.
In that case frame of the second scrollview will be huge and make scrolling imposible as we will try to use points of the screen. Instead we should visible frame.
Reviewed By: antiarchit
Differential Revision: D6819626
fbshipit-source-id: 27062f593485b4ec55ae8bd1a9c9a32a89630b92
* fb_isVisible using interfaceOrientation instead of Device orientation.
Summary:
[XCUIDevice sharedDevice].orientation may get values like FaceUp, which cause wrong calculation of the app frame size, in landscape.
With devices in Lab, standing portrait, this problem is less common. Working on development with devices on the table it happens more often causing a great deal of confusion.
From my tests, using app interfaceOrientation gives always the reality of the App.
Closes facebookarchive/WebDriverAgent#875
Reviewed By: marekcirkos
Differential Revision: D7067153
Pulled By: antiarchit
fbshipit-source-id: c6aa8f8823d0f43e5072a190c34df931d0d6b8b8
* Fix testIconsFromSearchDashboard integration test
Summary:
It might be there is more than one `IntegrationApp` icon on the dashboard while integration tests are running on Travis. Addresses https://travis-ci.org/facebook/WebDriverAgent/jobs/349725814
Closes facebookarchive/WebDriverAgent#883
Differential Revision: D7289614
Pulled By: marekcirkos
fbshipit-source-id: e5060888f2a752c039fcf815984e24579a3cef06
* Allow to override typing frequency for single typing request
Reviewed By: antiarchit
Differential Revision: D7615943
fbshipit-source-id: 9cb82dce23c02970d0c29613c7de4ebca0838361
* Include RoutingHTTPServer in copy to fix ISSUE #902
Summary:
Include RoutingHTTPServer in copy to fix ISSUE #902
Closes facebookarchive/WebDriverAgent#915
Differential Revision: D7947944
Pulled By: marekcirkos
fbshipit-source-id: ca60238fc3f715f753f084493aec5afa4524b21b
* Fix the incorrect tap coordinate in landscape mode.
Summary:
If SDK >= 11, the tap coordinate based on application is not correct when
the application orientation is landscape and
tapX > application portrait width or tapY > application portrait height.
Pass the window element to the method [FBElementCommands gestureCoordinateWithCoordinate:element:] will resolve the problem.
More details about the bug, please see the following issues: #705, #798, #856.
Notice: On iOS 10, if the application is not launched by wda, no elements will be found. See issue #732.
Closes facebookarchive/WebDriverAgent#878
Differential Revision: D7947931
Pulled By: marekcirkos
fbshipit-source-id: 4f8ef1484761b79c69f67df40293eea70bc08984
* Update flow-bin for WebDriverAgent's Inspector
Differential Revision: D8220228
fbshipit-source-id: cf08317ab2e50282373576fedb7c2b26b47969ad
* Handle infinitive numbers in elements rect
Summary:
In case testmanagerd has problems in calculating frames it may return 'inf' instead which does not behave well with JSON encoding.
Therfore checing for infs when formating JSON reponse
Reviewed By: antiarchit
Differential Revision: D7067158
fbshipit-source-id: 180400186af49f1353d93e9eb61d7306b8a1a0f6
* force touch support
Summary:
A couple of commands which make possible to force touch given element or point by coordinates. In fact – copy of the tap extension. Baked with integration tests.
Updated with mykola-mokhnach improvements in appium#79
Closes facebookarchive/WebDriverAgent#917
Differential Revision: D8220249
Pulled By: marekcirkos
fbshipit-source-id: 2a14ab5759894577a1f5e40f20b4a6d79e519419
* Support getting the element cache size, clearing the element cache
Summary:
Every time a user finds an element using the `element` or `elements` route, a new `XCUIElement` object is added to the session cache. The elements are never removed from the cache.
A very naïve script which goes to the home screen and queries for the 'Phone' element 1000 times in a row, will cause memory consumption (as measured by Xcode) of the WebDriverAgent to grow to approximately 126 MB. Net, it appears that every `XCUIElement` object consumes about 100KB of memory.
For sessions which persist for a long period of time (say, 30 minutes or more), this can eventually lead to an out of memory situation in which the WebDriverAgent crashes.
This PR tries to provide an 'escape hatch' for applications which want long-running sessions, by allowing them to:
- query the amount of elements in the cache
- clear the element cache
by adding two custom routes.
We're looking at other approaches to keep the cache size under control as well - e.g. by checking the element cache for duplicates and adding an option to remove 'stale' elements (elements which no longer exist); we'll try to submit PRs for that as well.
As usual, let me know what you think & happy to discuss further.
Closes facebookarchive/WebDriverAgent#896
Differential Revision: D8254682
Pulled By: marekcirkos
fbshipit-source-id: a200a570d9b4e71a6f2171419b39126dd9affca3
* Fix fb_framelessFuzzyMatchesElement method
Summary:
In XCUIElementTypeTable,attribute values of many XCUIElementTypeCell
instances are null.When fb_scrollToVisibleWithNormalizedScrollDistance
function is called by XCUIElementTypeCell instance,it is unable to
accurately slide the specified UI element.
Closes facebookarchive/WebDriverAgent#879
Differential Revision: D8255752
Pulled By: marekcirkos
fbshipit-source-id: 930f478417823ae0c0f79d1699d61af616f3c781
* Tune nullability
* comment out flaky tests
* Optimize force touch endpoint1 parent eec92e5 commit f864a39
File tree
16 files changed
+313
-30
lines changed- packages/webdriveragent
- Inspector
- WebDriverAgent.xcodeproj
- WebDriverAgentLib
- Categories
- Commands
- Utilities
- WebDriverAgentTests/IntegrationTests
16 files changed
+313
-30
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
302 | 302 | | |
303 | 303 | | |
304 | 304 | | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
305 | 308 | | |
306 | 309 | | |
307 | 310 | | |
| |||
656 | 659 | | |
657 | 660 | | |
658 | 661 | | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
659 | 665 | | |
660 | 666 | | |
661 | 667 | | |
| |||
955 | 961 | | |
956 | 962 | | |
957 | 963 | | |
| 964 | + | |
| 965 | + | |
958 | 966 | | |
959 | 967 | | |
960 | 968 | | |
| |||
1131 | 1139 | | |
1132 | 1140 | | |
1133 | 1141 | | |
| 1142 | + | |
1134 | 1143 | | |
1135 | 1144 | | |
1136 | 1145 | | |
| |||
1481 | 1490 | | |
1482 | 1491 | | |
1483 | 1492 | | |
| 1493 | + | |
1484 | 1494 | | |
1485 | 1495 | | |
1486 | 1496 | | |
| |||
1845 | 1855 | | |
1846 | 1856 | | |
1847 | 1857 | | |
| 1858 | + | |
1848 | 1859 | | |
1849 | 1860 | | |
1850 | 1861 | | |
| |||
1896 | 1907 | | |
1897 | 1908 | | |
1898 | 1909 | | |
| 1910 | + | |
1899 | 1911 | | |
1900 | 1912 | | |
1901 | 1913 | | |
| |||
Lines changed: 1 addition & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
| |||
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 62 | + | |
69 | 63 | | |
70 | 64 | | |
71 | 65 | | |
| |||
111 | 105 | | |
112 | 106 | | |
113 | 107 | | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | 108 | | |
120 | 109 | | |
121 | 110 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
Lines changed: 39 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
Lines changed: 64 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
26 | 37 | | |
27 | 38 | | |
28 | 39 | | |
| |||
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
44 | 50 | | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
48 | | - | |
49 | | - | |
| 54 | + | |
50 | 55 | | |
51 | 56 | | |
52 | 57 | | |
| |||
0 commit comments