Use double value as argument in FindMinutes function. #8864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
PR
singhashish-wpf
approved these changes
Mar 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Build failure in PR: #8863
Description
In Dotnet/runtime new TimeSpan.From overloads were added for int values.
PR: dotnet/runtime#98633
In WPF, we are using FromMinutes function from TimeSpan with value 10.
On addition of new surface API in runtime, C++/CLI reports it as ambiguous (between int and double)
Fixing it by setting the argument value as double
Risk
N/A
Microsoft Reviewers: Open in CodeFlow