Skip to content

Commit 32eaa68

Browse files
authored
Avoid initializing native tools twice (#3335)
1 parent eed3992 commit 32eaa68

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

eng/configure-toolset.ps1

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
1-
$DoNotAbortNativeToolsInstallationOnFailure = $true
2-
$DoNotDisplayNativeToolsInstallationWarnings = $true
3-
4-
. $PsScriptRoot\common\init-tools-native.ps1 -InstallDirectory $PSScriptRoot\..\.tools\native -GlobalJsonFile $PSScriptRoot\..\global.json
1+
$script:DoNotAbortNativeToolsInstallationOnFailure = $true
2+
$script:DoNotDisplayNativeToolsInstallationWarnings = $true

eng/packageContent.targets

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,50 +14,50 @@
1414
<PropertyGroup>
1515
<!-- Also in global.json -->
1616
<DotNetApiDocsNetCoreApp30>0.0.0.1</DotNetApiDocsNetCoreApp30>
17-
<IntellisenseXmlDir>$(RepositoryToolsDir)native\bin\dotnet-api-docs_netcoreapp3.0\$(DotNetApiDocsNetCoreApp30)\_intellisense\netcore-3.0\</IntellisenseXmlDir>
17+
<IntellisenseXmlDir>$(RepositoryToolsDir)\bin\dotnet-api-docs_netcoreapp3.0\$(DotNetApiDocsNetCoreApp30)\_intellisense\netcore-3.0\</IntellisenseXmlDir>
1818
</PropertyGroup>
1919

2020
<PropertyGroup>
2121
<IntellisenseXmlFileSource>$(IntellisenseXmlDir)$(AssemblyName).xml</IntellisenseXmlFileSource>
2222
<!-- TODO: remove when we get dotnet-api-docs_netcoreapp5.0 -->
2323
<IntellisenseXmlFileSource Condition="!Exists('$(IntellisenseXmlFileSource)')">$([System.IO.Path]::ChangeExtension('$(TargetPath)', '.xml'))</IntellisenseXmlFileSource>
24-
24+
2525
<IntellisenseXml Condition="'$(ProduceReferenceAssembly)' == 'true' And '$(PackageAsRefAndLib)' != 'true'" >$([System.IO.Path]::ChangeExtension('$(TargetRefPath)', '.xml'))</IntellisenseXml>
2626
<IntellisenseXml Condition="'$(PackageAsRefAndLib)' == 'true'" >$([System.IO.Path]::ChangeExtension('$(TargetPath)', '.xml'))</IntellisenseXml>
2727

2828
<IntellisenseXmlDir Condition="'$(IntellisenseXml)' != ''">$([System.IO.Path]::GetDirectoryName('$(IntellisenseXml)'))</IntellisenseXmlDir>
2929
</PropertyGroup>
30-
30+
3131
<Target Name="GetPackageContent"
3232
DependsOnTargets="SatelliteDllsProjectOutputGroup"
3333
Returns="@(PackageFile)">
3434
<ItemGroup>
3535
<PackageFile Include="$(TargetPath)" PackagePath="$(PackagePath)" />
3636
<PackageFile Condition="'$(IncludePdbInPackage)' == 'true'" Include="$(TargetDir)$(TargetName).pdb" PackagePath="$(PackagePath)" />
3737
<PackageFile Condition="'$(ProduceReferenceAssembly)' == 'true'" Include="$(TargetRefPath)" PackagePath="$(RefPackagePath)" />
38-
<PackageFile Condition="'$(ProduceReferenceAssembly)' == 'true' Or '$(PackageAsRefAndLib)' == 'true'"
39-
Include="$(IntellisenseXml)"
38+
<PackageFile Condition="'$(ProduceReferenceAssembly)' == 'true' Or '$(PackageAsRefAndLib)' == 'true'"
39+
Include="$(IntellisenseXml)"
4040
PackagePath="$(RefPackagePath)" />
4141
<PackageFile Condition="'$(PackageAsRefAndLib)' == 'true'" Include="$(TargetPath)" PackagePath="$(RefPackagePath)" />
4242
<PackageFile Condition="'$(IncludeResourcesInPackage)' == 'true'"
4343
Include="@(SatelliteDllsProjectOutputGroupOutput->'%(FinalOutputPath)')"
4444
PackagePath="$(PackagePath)/%(SatelliteDllsProjectOutputGroupOutput.Culture)" />
4545
</ItemGroup>
4646
</Target>
47-
47+
4848
<!-- xml files can be added here for intellisense -->
4949
<Target Name="CopyIntellisenseXmlsToTargetRefPath"
5050
AfterTargets="Build"
5151
Inputs="$(IntellisenseXmlFileSource)"
5252
Outputs="$(IntellisenseXml)"
5353
Condition="'$(ProduceReferenceAssembly)' == 'true' Or '$(PackageAsRefAndLib)' == 'true'">
54-
54+
5555
<Message Condition="!Exists('$(IntellisenseXmlFileSource)')"
5656
Text="$(IntellisenseXmlFileSource) is missing" />
5757

5858
<MakeDir Condition="!Exists('$(IntellisenseXmlDir)')"
5959
Directories="$([System.IO.Path]::GetDirectoryName('$(IntellisenseXml)'))" />
60-
60+
6161
<Copy SourceFiles="$(IntellisenseXmlFileSource)"
6262
Condition="Exists('$(IntellisenseXmlFileSource)')"
6363
DestinationFiles="$(IntellisenseXml)"

0 commit comments

Comments
 (0)