Enable nullable for dotnet test MTP implementation #50731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
force-pushed
the
dev/ygerges/mtp-nullable
branch
2 times, most recently
from
f4f68e2 to
c2f393b
Compare
Youssef1313
force-pushed
the
dev/ygerges/mtp-nullable
branch
from
c2f393b to
fd7e238
Compare
Youssef1313
commented
Sep 11, 2025
Comment on lines
+178
to
+179
| // TODO: Revise null suppression here. | ||
| artifact.TestDisplayName, artifact.FullPath!); |
Member
There was a problem hiding this comment.
The test application is always sending this.
We can still add some validation upon receiving the artifact message , but at the moment this PR should be good to go.
mariam-abdulla
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.