Refactor unit-tests to use TestProject apis

Author: ocalles

src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildADesktopExe.cs

@@ -830,69 +830,91 @@ public void It_places_package_satellites_correctly(bool crossTarget)
             outputDirectory.Should().HaveFile(@"fr\FluentValidation.resources.dll");
         }
 
-        [WindowsOnlyFact]
-        public void It_places_package_pdb_file_correctly()
+        [WindowsOnlyFact(Skip = "https://github.com/NuGet/Home/issues/6823")]
+        public void It_allows_TargetFrameworkVersion_to_be_capitalized()
         {
-            var testAsset = _testAssetsManager
-              .CopyTestAsset(
-                  "DesktopUsingPackageWithPdb")
-              .WithSource();
+            var testProject = new TestProject()
+            {
+                Name = "UppercaseTargetFrameworkVersion",
+                IsSdkProject = false,
+                IsExe = true,
+                TargetFrameworkVersion = "V4.6.2"
+            };
 
-            testAsset.Restore(Log);
+            var testAsset = _testAssetsManager.CreateTestProject(testProject);
+
+            var buildCommand = new BuildCommand(testAsset);
 
-            var buildCommand = new BuildCommand(Log, testAsset.TestRoot);
             buildCommand
                 .Execute()
                 .Should()
                 .Pass();
-
-            var outputDirectory = buildCommand.GetOutputDirectory("net46");
-            outputDirectory.Should().HaveFile("NServiceBus.Core.dll");
-            outputDirectory.Should().HaveFile("NServiceBus.Core.pdb");
-            outputDirectory.Should().HaveFile("NServiceBus.Core.xml");
         }
 
         [WindowsOnlyFact]
-        public void It_places_package_pdb_without_xml_file_correctly()
+        public void It_places_package_pdb_and_xml_files_correctly()
         {
-            var testAsset = _testAssetsManager
-              .CopyTestAsset(
-                  "DesktopUsingPackageWithPdbAndXml")
-              .WithSource();
+            var testProject = new TestProject()
+            {
+                Name = "DesktopUsingPackageWithPdbAndXml",
+                TargetFrameworks = ToolsetInfo.CurrentTargetFramework,
+                IsSdkProject = true, // open the project in the new project system
+                IsExe = true,
+            };
+
+            testProject.PackageReferences.Add(new TestPackageReference("NServiceBus", "6.4.0"));
+
+            // Copy xml files to output directory
+            testProject.AdditionalProperties.Add("PublishReferencesDocumentationFiles", "true");
+
+            var testAsset = _testAssetsManager.CreateTestProject(testProject);
 
             testAsset.Restore(Log);
 
             var buildCommand = new BuildCommand(Log, testAsset.TestRoot);
+
             buildCommand
                 .Execute()
                 .Should()
                 .Pass();
 
-            var outputDirectory = buildCommand.GetOutputDirectory("net46");
+            var outputDirectory = buildCommand.GetOutputDirectory(ToolsetInfo.CurrentTargetFramework);
             outputDirectory.Should().HaveFile("NServiceBus.Core.dll");
             outputDirectory.Should().HaveFile("NServiceBus.Core.pdb");
-            outputDirectory.Should().NotHaveFile("NServiceBus.Core.xml");
+            outputDirectory.Should().HaveFile("NServiceBus.Core.xml");
         }
 
-        [WindowsOnlyFact(Skip = "https://github.com/NuGet/Home/issues/6823")]
-        public void It_allows_TargetFrameworkVersion_to_be_capitalized()
+        [WindowsOnlyFact]
+        public void It_places_package_pdb_without_xml_file_correctly()
         {
             var testProject = new TestProject()
             {
-                Name = "UppercaseTargetFrameworkVersion",
-                IsSdkProject = false,
+                Name = "DesktopUsingPackageWithPdb",
+                TargetFrameworks = ToolsetInfo.CurrentTargetFramework,
+                IsSdkProject = true, // open the project in the new project system
                 IsExe = true,
-                TargetFrameworkVersion = "V4.6.2"
             };
 
+            testProject.PackageReferences.Add(new TestPackageReference("NServiceBus", "6.4.0"));
+
+            // Do not copy xml files to output directory
+            testProject.AdditionalProperties.Add("PublishReferencesDocumentationFiles", "false");
+
             var testAsset = _testAssetsManager.CreateTestProject(testProject);
 
-            var buildCommand = new BuildCommand(testAsset);
+            testAsset.Restore(Log);
+
+            var buildCommand = new BuildCommand(Log, testAsset.TestRoot);
 
             buildCommand
                 .Execute()
                 .Should()
                 .Pass();
+
+            var outputDirectory = buildCommand.GetOutputDirectory(ToolsetInfo.CurrentTargetFramework);
+            outputDirectory.Should().HaveFile("NServiceBus.Core.dll");
+            outputDirectory.Should().HaveFile("NServiceBus.Core.pdb");
+            outputDirectory.Should().NotHaveFile("NServiceBus.Core.xml");
         }
     }
 }