Skip to content

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Feb 12, 2024

  • rename JSProxyContext.NativeTID to JSNativeTID
  • pass TID to InstallMainSynchronizationContext and GCHandle back
  • don't use synchronous resolve for Task pre-resolved on another thread
  • fix CTS leak in WaitAssertsOnJSInteropThreads
  • rename mono_wasm_invoke_method_bound to mono_wasm_invoke_method
  • drop mono_wasm_invoke_method_raw in favor of mono_wasm_invoke_method
  • load segmentation-rules and symbols assets into worker
  • normalized functions in managed-exports.ts
  • renamed runtimeHelpers.proxyGCHandle
  • handle exit_code === undefined
  • handle document undefined in appendElementOnExit in worker
  • made loaderHelpers.invariantMode local variable
  • improved thread_dump for detached threads and UI thread
  • mono_wasm_init_threads asynchronously and earlier and moved the code
  • moved more logic into start_runtime
  • rename invoke_method_and_handle_exception to invoke_sync_method
  • fix RuntimeHelpers init of nativeExit and nativeAbort

- pass TID to InstallMainSynchronizationContext and GCHandle back
- don't use synchronous resolve for Tasks pre-resolved on another thread
- fix CTS leak in WaitAssertsOnJSInteropThreads
- rename mono_wasm_invoke_method_bound to mono_wasm_invoke_method
- drop mono_wasm_invoke_method_raw in favor of mono_wasm_invoke_method
- load segmentation-rules and symbols into worker
- normalized functions in managed-exports.ts
- renamed runtimeHelpers.proxyGCHandle
- handle exit_code === undefined
- handle document undefined in appendElementOnExit (worker)
- made loaderHelpers.invariantMode local variable
- improved thread dump for detached threads and UI thread
- mono_wasm_init_threads asynchronously and earlier and moved the code
- moved more logic into start_runtime()
-
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Feb 12, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Feb 12, 2024
@pavelsavara pavelsavara requested a review from maraf February 12, 2024 14:28
@pavelsavara pavelsavara self-assigned this Feb 12, 2024
@ghost
Copy link

ghost commented Feb 12, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • rename JSProxyContext.NativeTID to JSNativeTID
  • pass TID to InstallMainSynchronizationContext and GCHandle back
  • don't use synchronous resolve for Task pre-resolved on another thread
  • fix CTS leak in WaitAssertsOnJSInteropThreads
  • rename mono_wasm_invoke_method_bound to mono_wasm_invoke_method
  • drop mono_wasm_invoke_method_raw in favor of mono_wasm_invoke_method
  • load segmentation-rules and symbols assets into worker
  • normalized functions in managed-exports.ts
  • renamed runtimeHelpers.proxyGCHandle
  • handle exit_code === undefined
  • handle document undefined in appendElementOnExit in worker
  • made loaderHelpers.invariantMode local variable
  • improved thread_dump for detached threads and UI thread
  • mono_wasm_init_threads asynchronously and earlier and moved the code
  • moved more logic into start_runtime
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review February 12, 2024 16:12
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not spot anything ungood

pavelsavara and others added 2 commits February 13, 2024 08:01
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs

Co-authored-by: Marek Fišera <[email protected]>
# Conflicts:
#	src/mono/browser/runtime/startup.ts
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara merged commit 7317bfe into dotnet:main Feb 13, 2024
@pavelsavara pavelsavara deleted the browser_mt_prep1 branch February 13, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants