From 2872d82a6607f9cbab5b10cec9fc404e880a96cf Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Thu, 26 Oct 2023 15:04:22 +0000 Subject: [PATCH 1/7] Disabling tests failing in the last two weeks on MT. --- .../tests/BackgroundWorkerTests.cs | 1 + .../Conformance.dynamic.dynamicType.basic.cs | 1 + .../ObservableCollection_MethodsTest.cs | 1 + .../tests/events/EventsAdd.cs | 1 + .../tests/events/EventsRemove.cs | 13 +++++++++++++ .../tests/events/EventsReplace.cs | 3 +++ .../tests/Metadata/LargeTablesAndHeapsTests.cs | 1 + .../System.Runtime/tests/System/GuidTests.cs | 2 ++ .../tests/RandomNumberGeneratorTests.cs | 4 ++++ src/libraries/tests.proj | 8 ++++++++ 10 files changed, 35 insertions(+) diff --git a/src/libraries/System.ComponentModel.EventBasedAsync/tests/BackgroundWorkerTests.cs b/src/libraries/System.ComponentModel.EventBasedAsync/tests/BackgroundWorkerTests.cs index 670f201c6960de..2fa501af946424 100644 --- a/src/libraries/System.ComponentModel.EventBasedAsync/tests/BackgroundWorkerTests.cs +++ b/src/libraries/System.ComponentModel.EventBasedAsync/tests/BackgroundWorkerTests.cs @@ -91,6 +91,7 @@ public async Task RunWorkerAsync_NoOnWorkHandler_SetsResultToNull() private ManualResetEventSlim manualResetEvent3; + [ActiveIssue("https://github.com/dotnet/runtime/issues/94050", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))] public void TestCancelAsync() { diff --git a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs index 9c4eb3000ae8b6..238e4225b9d220 100644 --- a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs +++ b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs @@ -8868,6 +8868,7 @@ public enum MyEnum Third } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94048", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void DynamicCSharpRunTest() { diff --git a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_MethodsTest.cs b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_MethodsTest.cs index 5faf6b8d6b2261..29e9da1328f282 100644 --- a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_MethodsTest.cs +++ b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_MethodsTest.cs @@ -93,6 +93,7 @@ public static void ClearTest() /// /// Tests that we can remove items at a specific index, at the middle beginning and end. /// + [ActiveIssue("https://github.com/dotnet/runtime/issues/94045", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void RemoveAtTest() { diff --git a/src/libraries/System.Private.Xml.Linq/tests/events/EventsAdd.cs b/src/libraries/System.Private.Xml.Linq/tests/events/EventsAdd.cs index ab7ba66b3e1164..1764a721e549ac 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/events/EventsAdd.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/events/EventsAdd.cs @@ -514,6 +514,7 @@ public void ExecuteXAttributeVariation(XAttribute[] toAdd, XAttribute contextNod } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XAttributeXAttributeAddAtDeepLevel() { diff --git a/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs b/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs index 9998cb62aa0cee..73af998c270caf 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs @@ -19,6 +19,7 @@ public class EventsRemove new object[] { new XNode[] { new XComment("Comment") }, 0 }, new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") }, 1 } }; + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXDocumentVariationParams))] public void ExecuteXDocumentVariation(XNode[] content, int index) { @@ -51,6 +52,7 @@ public void ExecuteXDocumentVariation(XNode[] content, int index) new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") }, 2 }, new object[] { InputSpace.GetElement(100, 10).DescendantNodes().ToArray(), 50 } }; + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XNode[] content, int index) { @@ -79,6 +81,7 @@ public void ExecuteXElementVariation(XNode[] content, int index) new object[] { new XAttribute[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") }, 0 }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray(), 10 } }; + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXAttributeVariationParams))] public void ExecuteXAttributeVariation(XAttribute[] content, int index) { @@ -146,6 +149,7 @@ public void XElementWorkOnTextNodes2() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XElementWorkOnTextNodes3() { @@ -172,6 +176,7 @@ public void XElementWorkOnTextNodes3() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XElementWorkOnTextNodes4() { @@ -192,6 +197,7 @@ public void XElementWorkOnTextNodes4() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XAttributeRemoveOneByOne() { @@ -218,6 +224,7 @@ public void XAttributeRemoveOneByOne() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XElementRemoveOneByOne() { @@ -244,6 +251,7 @@ public void XElementRemoveOneByOne() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XAttributeRemoveSeq() { @@ -267,6 +275,7 @@ public void XAttributeRemoveSeq() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XElementRemoveSeq() { @@ -290,6 +299,7 @@ public void XElementRemoveSeq() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XElementParentedXNode() { @@ -311,6 +321,7 @@ public void XElementParentedXNode() element.Verify(); } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XElementChangeAttributesParentInThePreEventHandler() { @@ -370,6 +381,7 @@ public void ExecuteXDocumentVariation(XNode[] content) new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") } }, new object[] { InputSpace.GetElement(100, 10).DescendantNodes().ToArray() } }; + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XNode[] content) { @@ -485,6 +497,7 @@ public class EventsRemoveAll new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray() }, new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XElement("parent", new XElement("child", "child text")) } } }; + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XObject[] content) { diff --git a/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs b/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs index d29c8a47e4758a..5f99afc745ac93 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs @@ -186,6 +186,7 @@ public class EvensReplaceAttributes new object[] { new XAttribute[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") } }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray() } }; + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXAttributeVariationParams))] public void ExecuteXAttributeVariation(XAttribute[] content) { @@ -225,6 +226,7 @@ public class EventsReplaceAll new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray() }, new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XElement("parent", new XElement("child", "child text")) } } }; + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XObject[] toReplace) { @@ -249,6 +251,7 @@ public void ExecuteXElementVariation(XObject[] toReplace) } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void ElementWithAttributes() { diff --git a/src/libraries/System.Reflection.Metadata/tests/Metadata/LargeTablesAndHeapsTests.cs b/src/libraries/System.Reflection.Metadata/tests/Metadata/LargeTablesAndHeapsTests.cs index c37dd238618436..68923d8e02c14a 100644 --- a/src/libraries/System.Reflection.Metadata/tests/Metadata/LargeTablesAndHeapsTests.cs +++ b/src/libraries/System.Reflection.Metadata/tests/Metadata/LargeTablesAndHeapsTests.cs @@ -70,6 +70,7 @@ public void Baseline() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94044", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void Guids() { diff --git a/src/libraries/System.Runtime/tests/System/GuidTests.cs b/src/libraries/System.Runtime/tests/System/GuidTests.cs index 125db99a5357ae..56c39a8dc08546 100644 --- a/src/libraries/System.Runtime/tests/System/GuidTests.cs +++ b/src/libraries/System.Runtime/tests/System/GuidTests.cs @@ -119,6 +119,7 @@ public static void Ctor_UInt_UShort_UShort_Byte_Byte_Byte_Byte_Byte_Byte_Byte_By Assert.Equal(s_testGuid, guid); } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94043", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void NewGuid() { @@ -129,6 +130,7 @@ public static void NewGuid() Assert.NotEqual(guid1, guid2); } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94043", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void NewGuid_Randomness() { diff --git a/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs b/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs index f7b4ad2de4f772..e698b79ef7f96b 100644 --- a/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs +++ b/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs @@ -191,6 +191,7 @@ public static void GetBytes_Array_Offset_ZeroCount() } } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94041", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory] [InlineData(10)] [InlineData(256)] @@ -616,6 +617,7 @@ public static void GetString_SingleChoice() Assert.Equal(new string('!', 42), result); } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94041", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void GetItems_CoinFlip_Int_RandomDistribution() { @@ -641,6 +643,7 @@ public static void GetItems_CoinFlip_Bool_RandomDistribution() VerifyDistribution(generated, 0.5); } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94041", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void GetItems_Bool_NoDeduplication() { @@ -697,6 +700,7 @@ public static void GetHexString_Empty() RandomNumberGenerator.GetHexString(buffer); // Shouldn't throw. } + [ActiveIssue("https://github.com/dotnet/runtime/issues/94040", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory] [MemberData(nameof(GetHexStringLengths))] public static void GetHexString_Allocating_Random(int length) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index b7ef37c39fe794..97634df415917e 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -385,12 +385,20 @@ + + + + + + + + From 218c8bd0485ab8518c6deba754f7be6f79c4d9e8 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Thu, 26 Oct 2023 15:36:14 +0000 Subject: [PATCH 2/7] Failures from https://github.com/dotnet/runtime/pull/93466 should not apply. --- .../Conformance.dynamic.dynamicType.basic.cs | 1 - .../tests/events/EventsAdd.cs | 1 - .../tests/events/EventsRemove.cs | 37 ++++++------------- .../tests/events/EventsReplace.cs | 7 +--- .../Metadata/LargeTablesAndHeapsTests.cs | 1 - .../System.Runtime/tests/System/GuidTests.cs | 2 - .../tests/RandomNumberGeneratorTests.cs | 10 ++--- 7 files changed, 17 insertions(+), 42 deletions(-) diff --git a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs index 238e4225b9d220..9c4eb3000ae8b6 100644 --- a/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs +++ b/src/libraries/System.Dynamic.Runtime/tests/Dynamic.DynamicType/Conformance.dynamic.dynamicType.basic.cs @@ -8868,7 +8868,6 @@ public enum MyEnum Third } - [ActiveIssue("https://github.com/dotnet/runtime/issues/94048", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void DynamicCSharpRunTest() { diff --git a/src/libraries/System.Private.Xml.Linq/tests/events/EventsAdd.cs b/src/libraries/System.Private.Xml.Linq/tests/events/EventsAdd.cs index 1764a721e549ac..ab7ba66b3e1164 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/events/EventsAdd.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/events/EventsAdd.cs @@ -514,7 +514,6 @@ public void ExecuteXAttributeVariation(XAttribute[] toAdd, XAttribute contextNod } } - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void XAttributeXAttributeAddAtDeepLevel() { diff --git a/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs b/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs index 73af998c270caf..8612f8e7e69e41 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs @@ -19,7 +19,6 @@ public class EventsRemove new object[] { new XNode[] { new XComment("Comment") }, 0 }, new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") }, 1 } }; - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXDocumentVariationParams))] public void ExecuteXDocumentVariation(XNode[] content, int index) { @@ -51,8 +50,7 @@ public void ExecuteXDocumentVariation(XNode[] content, int index) new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") }, 1 }, new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") }, 2 }, new object[] { InputSpace.GetElement(100, 10).DescendantNodes().ToArray(), 50 } - }; - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + }; [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XNode[] content, int index) { @@ -80,8 +78,7 @@ public void ExecuteXElementVariation(XNode[] content, int index) new object[] { new XAttribute[] { new XAttribute("xxx", "yyy"), new XAttribute("a", "aa") }, 1 }, new object[] { new XAttribute[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") }, 0 }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray(), 10 } - }; - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + }; [Theory, MemberData(nameof(ExecuteXAttributeVariationParams))] public void ExecuteXAttributeVariation(XAttribute[] content, int index) { @@ -148,8 +145,7 @@ public void XElementWorkOnTextNodes2() Assert.Equal("text1text0text2", elem.Value); } } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void XElementWorkOnTextNodes3() { @@ -175,8 +171,7 @@ public void XElementWorkOnTextNodes3() Assert.Equal("text1text0text2", elem.Value); } } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void XElementWorkOnTextNodes4() { @@ -196,8 +191,7 @@ public void XElementWorkOnTextNodes4() Assert.Equal("text2text0text1", elem.Value); } } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void XAttributeRemoveOneByOne() { @@ -223,8 +217,7 @@ public void XAttributeRemoveOneByOne() Assert.True(XNode.DeepEquals(xDoc, xDocOriginal), "Undo did not work!"); } } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void XElementRemoveOneByOne() { @@ -250,8 +243,7 @@ public void XElementRemoveOneByOne() Assert.True(XNode.DeepEquals(xDoc, xDocOriginal), "Undo did not work!"); } } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void XAttributeRemoveSeq() { @@ -274,8 +266,7 @@ public void XAttributeRemoveSeq() Assert.True(XNode.DeepEquals(xDoc, xDocOriginal), "Undo did not work!"); } } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void XElementRemoveSeq() { @@ -298,8 +289,7 @@ public void XElementRemoveSeq() Assert.True(XNode.DeepEquals(xDoc, xDocOriginal), "Undo did not work!"); } } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void XElementParentedXNode() { @@ -320,8 +310,7 @@ public void XElementParentedXNode() Assert.Throws(() => { child.Remove(); }); element.Verify(); } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void XElementChangeAttributesParentInThePreEventHandler() { @@ -380,8 +369,7 @@ public void ExecuteXDocumentVariation(XNode[] content) new object[] { new XNode[] { new XComment("Comment") } }, new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") } }, new object[] { InputSpace.GetElement(100, 10).DescendantNodes().ToArray() } - }; - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + }; [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XNode[] content) { @@ -496,8 +484,7 @@ public class EventsRemoveAll new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") } }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray() }, new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XElement("parent", new XElement("child", "child text")) } } - }; - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + }; [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XObject[] content) { diff --git a/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs b/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs index 5f99afc745ac93..ea14638b21171d 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs @@ -186,7 +186,6 @@ public class EvensReplaceAttributes new object[] { new XAttribute[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") } }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray() } }; - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory, MemberData(nameof(ExecuteXAttributeVariationParams))] public void ExecuteXAttributeVariation(XAttribute[] content) { @@ -225,8 +224,7 @@ public class EventsReplaceAll new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") } }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray() }, new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XElement("parent", new XElement("child", "child text")) } } - }; - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + }; [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XObject[] toReplace) { @@ -250,8 +248,7 @@ public void ExecuteXElementVariation(XObject[] toReplace) Assert.True(xElem.Attributes().EqualsAllAttributes(xElemOriginal.Attributes(), Helpers.MyAttributeComparer), "Undo did not work!"); } } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94039", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public void ElementWithAttributes() { diff --git a/src/libraries/System.Reflection.Metadata/tests/Metadata/LargeTablesAndHeapsTests.cs b/src/libraries/System.Reflection.Metadata/tests/Metadata/LargeTablesAndHeapsTests.cs index 68923d8e02c14a..c37dd238618436 100644 --- a/src/libraries/System.Reflection.Metadata/tests/Metadata/LargeTablesAndHeapsTests.cs +++ b/src/libraries/System.Reflection.Metadata/tests/Metadata/LargeTablesAndHeapsTests.cs @@ -70,7 +70,6 @@ public void Baseline() } } - [ActiveIssue("https://github.com/dotnet/runtime/issues/94044", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public void Guids() { diff --git a/src/libraries/System.Runtime/tests/System/GuidTests.cs b/src/libraries/System.Runtime/tests/System/GuidTests.cs index 56c39a8dc08546..125db99a5357ae 100644 --- a/src/libraries/System.Runtime/tests/System/GuidTests.cs +++ b/src/libraries/System.Runtime/tests/System/GuidTests.cs @@ -119,7 +119,6 @@ public static void Ctor_UInt_UShort_UShort_Byte_Byte_Byte_Byte_Byte_Byte_Byte_By Assert.Equal(s_testGuid, guid); } - [ActiveIssue("https://github.com/dotnet/runtime/issues/94043", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void NewGuid() { @@ -130,7 +129,6 @@ public static void NewGuid() Assert.NotEqual(guid1, guid2); } - [ActiveIssue("https://github.com/dotnet/runtime/issues/94043", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void NewGuid_Randomness() { diff --git a/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs b/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs index e698b79ef7f96b..70406e5b39cfeb 100644 --- a/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs +++ b/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs @@ -191,7 +191,6 @@ public static void GetBytes_Array_Offset_ZeroCount() } } - [ActiveIssue("https://github.com/dotnet/runtime/issues/94041", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Theory] [InlineData(10)] [InlineData(256)] @@ -616,8 +615,7 @@ public static void GetString_SingleChoice() string result = RandomNumberGenerator.GetString("!", 42); Assert.Equal(new string('!', 42), result); } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94041", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public static void GetItems_CoinFlip_Int_RandomDistribution() { @@ -642,8 +640,7 @@ public static void GetItems_CoinFlip_Bool_RandomDistribution() RandomNumberGenerator.GetItems(choices, generated); VerifyDistribution(generated, 0.5); } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94041", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Fact] public static void GetItems_Bool_NoDeduplication() { @@ -699,8 +696,7 @@ public static void GetHexString_Empty() Span buffer = Span.Empty; RandomNumberGenerator.GetHexString(buffer); // Shouldn't throw. } - - [ActiveIssue("https://github.com/dotnet/runtime/issues/94040", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] + [Theory] [MemberData(nameof(GetHexStringLengths))] public static void GetHexString_Allocating_Random(int length) From 989006214a9a13845c4d40b885ac0b75cceaadb6 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Thu, 26 Oct 2023 15:49:15 +0000 Subject: [PATCH 3/7] Remove duplicate + other issues connnected to test PR runs. --- .../ObservableCollection/ObservableCollection_MethodsTest.cs | 1 - src/libraries/tests.proj | 3 --- 2 files changed, 4 deletions(-) diff --git a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_MethodsTest.cs b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_MethodsTest.cs index 29e9da1328f282..5faf6b8d6b2261 100644 --- a/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_MethodsTest.cs +++ b/src/libraries/System.ObjectModel/tests/ObservableCollection/ObservableCollection_MethodsTest.cs @@ -93,7 +93,6 @@ public static void ClearTest() /// /// Tests that we can remove items at a specific index, at the middle beginning and end. /// - [ActiveIssue("https://github.com/dotnet/runtime/issues/94045", typeof(PlatformDetection), nameof(PlatformDetection.IsWasmThreadingSupported))] [Fact] public static void RemoveAtTest() { diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 97634df415917e..22657104139979 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -385,7 +385,6 @@ - @@ -397,8 +396,6 @@ - - From 599654b479c0f6f1650a31d660c8862cef7413f8 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Thu, 26 Oct 2023 15:58:23 +0000 Subject: [PATCH 4/7] Cleanup --- .../tests/events/EventsRemove.cs | 24 +++++++++---------- .../tests/events/EventsReplace.cs | 4 ++-- .../tests/RandomNumberGeneratorTests.cs | 6 ++--- src/libraries/tests.proj | 4 ---- 4 files changed, 17 insertions(+), 21 deletions(-) diff --git a/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs b/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs index 8612f8e7e69e41..9998cb62aa0cee 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/events/EventsRemove.cs @@ -50,7 +50,7 @@ public void ExecuteXDocumentVariation(XNode[] content, int index) new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") }, 1 }, new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") }, 2 }, new object[] { InputSpace.GetElement(100, 10).DescendantNodes().ToArray(), 50 } - }; + }; [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XNode[] content, int index) { @@ -78,7 +78,7 @@ public void ExecuteXElementVariation(XNode[] content, int index) new object[] { new XAttribute[] { new XAttribute("xxx", "yyy"), new XAttribute("a", "aa") }, 1 }, new object[] { new XAttribute[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") }, 0 }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray(), 10 } - }; + }; [Theory, MemberData(nameof(ExecuteXAttributeVariationParams))] public void ExecuteXAttributeVariation(XAttribute[] content, int index) { @@ -145,7 +145,7 @@ public void XElementWorkOnTextNodes2() Assert.Equal("text1text0text2", elem.Value); } } - + [Fact] public void XElementWorkOnTextNodes3() { @@ -171,7 +171,7 @@ public void XElementWorkOnTextNodes3() Assert.Equal("text1text0text2", elem.Value); } } - + [Fact] public void XElementWorkOnTextNodes4() { @@ -191,7 +191,7 @@ public void XElementWorkOnTextNodes4() Assert.Equal("text2text0text1", elem.Value); } } - + [Fact] public void XAttributeRemoveOneByOne() { @@ -217,7 +217,7 @@ public void XAttributeRemoveOneByOne() Assert.True(XNode.DeepEquals(xDoc, xDocOriginal), "Undo did not work!"); } } - + [Fact] public void XElementRemoveOneByOne() { @@ -243,7 +243,7 @@ public void XElementRemoveOneByOne() Assert.True(XNode.DeepEquals(xDoc, xDocOriginal), "Undo did not work!"); } } - + [Fact] public void XAttributeRemoveSeq() { @@ -266,7 +266,7 @@ public void XAttributeRemoveSeq() Assert.True(XNode.DeepEquals(xDoc, xDocOriginal), "Undo did not work!"); } } - + [Fact] public void XElementRemoveSeq() { @@ -289,7 +289,7 @@ public void XElementRemoveSeq() Assert.True(XNode.DeepEquals(xDoc, xDocOriginal), "Undo did not work!"); } } - + [Fact] public void XElementParentedXNode() { @@ -310,7 +310,7 @@ public void XElementParentedXNode() Assert.Throws(() => { child.Remove(); }); element.Verify(); } - + [Fact] public void XElementChangeAttributesParentInThePreEventHandler() { @@ -369,7 +369,7 @@ public void ExecuteXDocumentVariation(XNode[] content) new object[] { new XNode[] { new XComment("Comment") } }, new object[] { new XNode[] { new XText(""), new XText(" "), new XText("\t") } }, new object[] { InputSpace.GetElement(100, 10).DescendantNodes().ToArray() } - }; + }; [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XNode[] content) { @@ -484,7 +484,7 @@ public class EventsRemoveAll new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") } }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray() }, new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XElement("parent", new XElement("child", "child text")) } } - }; + }; [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XObject[] content) { diff --git a/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs b/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs index ea14638b21171d..d29c8a47e4758a 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs +++ b/src/libraries/System.Private.Xml.Linq/tests/events/EventsReplace.cs @@ -224,7 +224,7 @@ public class EventsReplaceAll new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XAttribute("{a}xxx", "a_yyy") } }, new object[] { InputSpace.GetAttributeElement(10, 1000).Elements().Attributes().ToArray() }, new object[] { new XObject[] { new XAttribute("{b}xxx", "b_yyy"), new XElement("parent", new XElement("child", "child text")) } } - }; + }; [Theory, MemberData(nameof(ExecuteXElementVariationParams))] public void ExecuteXElementVariation(XObject[] toReplace) { @@ -248,7 +248,7 @@ public void ExecuteXElementVariation(XObject[] toReplace) Assert.True(xElem.Attributes().EqualsAllAttributes(xElemOriginal.Attributes(), Helpers.MyAttributeComparer), "Undo did not work!"); } } - + [Fact] public void ElementWithAttributes() { diff --git a/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs b/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs index 70406e5b39cfeb..f7b4ad2de4f772 100644 --- a/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs +++ b/src/libraries/System.Security.Cryptography/tests/RandomNumberGeneratorTests.cs @@ -615,7 +615,7 @@ public static void GetString_SingleChoice() string result = RandomNumberGenerator.GetString("!", 42); Assert.Equal(new string('!', 42), result); } - + [Fact] public static void GetItems_CoinFlip_Int_RandomDistribution() { @@ -640,7 +640,7 @@ public static void GetItems_CoinFlip_Bool_RandomDistribution() RandomNumberGenerator.GetItems(choices, generated); VerifyDistribution(generated, 0.5); } - + [Fact] public static void GetItems_Bool_NoDeduplication() { @@ -696,7 +696,7 @@ public static void GetHexString_Empty() Span buffer = Span.Empty; RandomNumberGenerator.GetHexString(buffer); // Shouldn't throw. } - + [Theory] [MemberData(nameof(GetHexStringLengths))] public static void GetHexString_Allocating_Random(int length) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 22657104139979..b50547f13b1628 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -385,14 +385,10 @@ - - - - From 0e138d3ae27817f26cbab90d82718108fbf72baa Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Thu, 26 Oct 2023 16:51:47 +0000 Subject: [PATCH 5/7] Increasing num of threads instead of disabling. --- .../tests/System.Threading.ThreadPool.Tests.csproj | 1 + src/libraries/tests.proj | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj b/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj index 0cb21c9d38492b..98ec6e35bb43db 100644 --- a/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj +++ b/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj @@ -3,6 +3,7 @@ true $(NetCoreAppCurrent) true + <_WasmPThreadPoolSize Condition="'$(MonoWasmBuildVariant)' == 'multithread'">16 diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index b50547f13b1628..b7ef37c39fe794 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -385,7 +385,6 @@ - From 10222c08045f6a5f78561daeb7ce7091fb1cad6b Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Fri, 27 Oct 2023 09:24:45 +0200 Subject: [PATCH 6/7] Update System.Threading.ThreadPool.Tests.csproj 16 was too low, still failing --- .../tests/System.Threading.ThreadPool.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj b/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj index 98ec6e35bb43db..bbd06e3e136ecc 100644 --- a/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj +++ b/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj @@ -3,7 +3,7 @@ true $(NetCoreAppCurrent) true - <_WasmPThreadPoolSize Condition="'$(MonoWasmBuildVariant)' == 'multithread'">16 + <_WasmPThreadPoolSize Condition="'$(MonoWasmBuildVariant)' == 'multithread'">32 From 32456f9fd9dcff84eea416ffd258b77bb0a6ae2c Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Fri, 27 Oct 2023 11:15:37 +0200 Subject: [PATCH 7/7] Update System.Threading.ThreadPool.Tests.csproj 32 was failing --- .../tests/System.Threading.ThreadPool.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj b/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj index bbd06e3e136ecc..b32acd02135625 100644 --- a/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj +++ b/src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj @@ -3,7 +3,7 @@ true $(NetCoreAppCurrent) true - <_WasmPThreadPoolSize Condition="'$(MonoWasmBuildVariant)' == 'multithread'">32 + <_WasmPThreadPoolSize Condition="'$(MonoWasmBuildVariant)' == 'multithread'">64