Remove uses of SR.GetResourceString throughout the libs #87912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsFixes #81338. Cc @dotnet/ilc-contrib @stephentoub
|
src/libraries/System.Transactions.Local/src/System/Transactions/Oletx/OletxTransaction.cs
Show resolved
Hide resolved
src/libraries/System.Text.Encoding.CodePages/src/System/Text/BaseCodePageEncoding.netcoreapp.cs
Show resolved
Hide resolved
MichalStrehovsky
changed the title
stephentoub
reviewed
Jun 22, 2023
src/libraries/Microsoft.Extensions.Primitives/src/ThrowHelper.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 22, 2023
...ibraries/System.ComponentModel.TypeConverter/src/System/Timers/TimersDescriptionAttribute.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jun 22, 2023
Member
|
Do we want to use the BannedApiAnalyzer to make sure that we don't re-add usages of |
Member
Author
The API is private so the chances are pretty low I think (someone would have to make it public/internal and ignore the comment right above). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81338.
Cc @dotnet/ilc-contrib @stephentoub