Skip to content

Delete GT_CNS_LNG #85951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Delete GT_CNS_LNG #85951

wants to merge 7 commits into from

Conversation

@SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented May 8, 2023

GT_CNS_LNG is an oper used for integral constants on 32 bit targets. On 64 bit targets, GT_CNS_INT is used for all integral constants. This is a bit of a hindrance for 32 bit target CQ, as it forces the natural flow of code to not consider long constants, and in general it seems odd to have one of the fundamental IR concepts (integer constants) be target-specific.

This change deletes GT_CNS_LNG, in favor of representing all integer constants with GT_CNS_INT.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels May 8, 2023
@ghost
Copy link

ghost commented May 8, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

GT_CNS_LNG is an oper used for integral constants on 32 bit targets. On 64 bit targets, GT_CNS_INT is used for all integral constants. This is a bit of a hindrance for 32 bit target CQ, as it forces the natural flow of code to not consider long constants, and in general it seems odd to have one of the fundamental IR concepts (integer constants) be target-specific.

This change deletes GT_CNS_LNG, in favor of representing all integer constants with GT_CNS_INT.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

tannergooding
tannergooding reviewed May 9, 2023
View reviewed changes
@SingleAccretion SingleAccretion force-pushed the No-Cns-Lng branch 2 times, most recently from 3653cd1 to b32ad59 Compare May 10, 2023 07:54
@drcjt drcjt mentioned this pull request May 15, 2023
Open
@build-analysis build-analysis bot mentioned this pull request May 25, 2023
Closed
@ghost ghost closed this Jun 24, 2023
@ghost
Copy link

ghost commented Jun 24, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost closed this Jul 25, 2023
@ghost
Copy link

ghost commented Jul 25, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost closed this Aug 24, 2023
@ghost
Copy link

ghost commented Aug 24, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost closed this Sep 24, 2023
@ghost
Copy link

ghost commented Sep 24, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jul 16, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Aug 15, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Sep 14, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Oct 15, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Nov 14, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Dec 14, 2024

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Jan 13, 2025

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Feb 13, 2025

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 15, 2025

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

IDisposable
IDisposable reviewed Mar 19, 2025
View reviewed changes
src/coreclr/jit/codegenarm64.cpp
ssize_t compareImm = op2->AsIntCon()->IconValue();

assert(isPow2(((size_t)compareImm)));
uint64_t compareImm = op2->AsIntCon()->IntegralValueUnsigned();
Copy link
Contributor

@IDisposable IDisposable Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be a perf regression cause... if uint64_t isn't treated the same as ssize_t

@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 18, 2025

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding left review comments

+1 more reviewer

@IDisposable IDisposable IDisposable left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SingleAccretion @AndyAyersMS @IDisposable @tannergooding