-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser] loader ES6 module #85730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] loader ES6 module #85730
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailswip
|
f1cded4 to
cac6aef
Compare
…nd native js files, remove it from loader js
# Conflicts: # src/mono/wasm/runtime/jiterpreter-trace-generator.ts
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
WBT fails with All other CI failures are known. |
ilonatommy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| /** | ||
| * query string to be used for asset loading | ||
| */ | ||
| assetUniqueQuery?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the benefit over WebAssemblyStartOptions.loadBootResource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could unify those later. Right now, the loadBootResource is not there for non-blazor templates.
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs
Show resolved
Hide resolved
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs
Outdated
Show resolved
Hide resolved
src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/GenerateWasmBootJson.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maraf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
|
This appears to have caused a massive regression in jsimport/export in browserbench? |
Split the
dotnet.jsinto 3 ES6 modules.dotnet.jssrc\mono\wasm\runtime\loader\foldermono-config.jsonorboot.config.jsondotnet.runtime.jsanddotnet.nativejsby looking at theconfig.assetsdotnet.runtime.jssrc\mono\wasm\runtime\folder except/loaderfolderdotnet.native.jsdotnet.native.wasm,dotnet.native.symbols.js,dotnet.native.worker.jsdotnet.nativeis the new prefix name.future benefits
dotnet.js. The loader would not change on re-link with workload.Other changes
assetUniqueQuerywhich is appended to asset names (so that we could have multiple instances of ES6 modules)loaderHelpersis similar toruntimeHelpersbut is populated by "loader". It passes methods and state between modules.find_corlib_classandfind_class_in_assemblywould not always throw when they don't find the class.js-module-runtime,js-module-dotnet,js-module-nativeModule.importsfunctionality, droppedDotnetModuleConfigImportsMONO.mono_wasm_load_configfrom legacy APIrequirepolyfill on NodeJSlocateFilepolyfillcreateEmscriptenis worth reviewSelfContaineddotnet.native.worker.jsnow loadsdotnet.jsloader first