-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Delete GT_FIELD
#85568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete GT_FIELD
#85568
Conversation
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsWith the removal Diffs:
A number of
|
d347221 to
6ea357a
Compare
6ea357a to
83ea05b
Compare
|
Diffs - see header comment. @dotnet/jit-contrib |
jakobbotsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice to see these gone.
|
Failure is known. |
With the removal
ASG,FIELDis the only location node that does not have aSTOREequivalent, thus this change removes it in favor of importingIND/BLK(FIELD_ADDR).Diffs:
FIELD_ADDRreturn buffer argument for a GDV call arg because it is correctly marked withGTF_EXCEPT.OBJ(LCL_ADDR)args handling from local morph ref counting #85544.A number of
TODO-FIELDs were added, I intend to address them separately.