Skip to content

SimdAsHWIntrinsic improvements and cleanup #80134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 6, 2023
Merged

SimdAsHWIntrinsic improvements and cleanup #80134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7309f81
Merge common code paths in simdashwintrinsic.cpp
tannergooding Jan 3, 2023
82256b1
Fixing a bug in the WithElement node for CreateFromVector
tannergooding Jan 3, 2023
5edcbb6
Ensure simdashwintrinsic paths consistently use the gtNewSimd*Node he…
tannergooding Jan 3, 2023
8843b24
Ensure remaining simdashwintrinsic paths use the gtNewSimd*Node helpers
tannergooding Jan 3, 2023
edb2ce8
Consistently use fgMakeMultiUse in the gtNewSimd*Node APIs
tannergooding Jan 3, 2023
359a331
Merge remote-tracking branch 'dotnet/main' into simplify-simdashw
tannergooding Jan 3, 2023
443ff86
Applying formatting patch
tannergooding Jan 3, 2023
53a3e7b
Ensure isSimdAsHWIntrinsic gets passed through
tannergooding Jan 3, 2023
9af73c7
Revert "Consistently use fgMakeMultiUse in the gtNewSimd*Node APIs"
tannergooding Jan 4, 2023
e8516fa
Handle SN_op_UnaryNegation for Vector2/3/4 on Mono
tannergooding Jan 4, 2023
4e263aa
Ensure short, ushort, float, and double don't assert for Vector128_Do…
tannergooding Jan 6, 2023
e5e6e2b
Merge remote-tracking branch 'dotnet/main' into simplify-simdashw
tannergooding Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20566,8 +20566,7 @@ GenTree* Compiler::gtNewSimdCmpOpAllNode(genTreeOps op,
intrinsic = NI_Vector128_op_Equality;
}

op1 = gtNewSimdCmpOpNode(op, simdType, op1, op2, simdBaseJitType, simdSize,
/* isSimdAsHWIntrinsic */ false);
op1 = gtNewSimdCmpOpNode(op, simdType, op1, op2, simdBaseJitType, simdSize, isSimdAsHWIntrinsic);
op2 = gtNewAllBitsSetConNode(simdType);

if (simdBaseType == TYP_FLOAT)
Expand Down Expand Up @@ -20606,8 +20605,7 @@ GenTree* Compiler::gtNewSimdCmpOpAllNode(genTreeOps op,
intrinsic = NI_Vector128_op_Equality;
}

op1 = gtNewSimdCmpOpNode(op, simdType, op1, op2, simdBaseJitType, simdSize,
/* isSimdAsHWIntrinsic */ false);
op1 = gtNewSimdCmpOpNode(op, simdType, op1, op2, simdBaseJitType, simdSize, isSimdAsHWIntrinsic);
op2 = gtNewAllBitsSetConNode(simdType);

if (simdBaseType == TYP_FLOAT)
Expand Down Expand Up @@ -20688,8 +20686,7 @@ GenTree* Compiler::gtNewSimdCmpOpAnyNode(genTreeOps op,
intrinsic = NI_Vector128_op_Inequality;
}

op1 = gtNewSimdCmpOpNode(op, simdType, op1, op2, simdBaseJitType, simdSize,
/* isSimdAsHWIntrinsic */ false);
op1 = gtNewSimdCmpOpNode(op, simdType, op1, op2, simdBaseJitType, simdSize, isSimdAsHWIntrinsic);
op2 = gtNewZeroConNode(simdType);

if (simdBaseType == TYP_FLOAT)
Expand Down Expand Up @@ -20732,8 +20729,7 @@ GenTree* Compiler::gtNewSimdCmpOpAnyNode(genTreeOps op,

intrinsic = (simdSize == 8) ? NI_Vector64_op_Inequality : NI_Vector128_op_Inequality;

op1 = gtNewSimdCmpOpNode(op, simdType, op1, op2, simdBaseJitType, simdSize,
/* isSimdAsHWIntrinsic */ false);
op1 = gtNewSimdCmpOpNode(op, simdType, op1, op2, simdBaseJitType, simdSize, isSimdAsHWIntrinsic);
op2 = gtNewZeroConNode(simdType);

if (simdBaseType == TYP_FLOAT)
Expand Down
3 changes: 3 additions & 0 deletions src/coreclr/jit/hwintrinsicxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,9 @@ GenTree* Compiler::impBaseIntrinsic(NamedIntrinsic intrinsic,
{
assert(sig->numArgs == 2);

impSpillSideEffect(true,
verCurrentState.esStackDepth - 2 DEBUGARG("Spilling op1 side effects for HWIntrinsic"));

op2 = impSIMDPopStack(retType);
op1 = impSIMDPopStack(retType);

Expand Down
Loading