Skip to content

[wasi] compile with libs.native #79046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Jan 7, 2023
Merged

[wasi] compile with libs.native #79046

merged 56 commits into from
Jan 7, 2023

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Nov 30, 2022 •
edited
Loading

Contributes to #65895

  • can compile mono+libs with WASI SDK
  • can run hello world sample with wasmtime
  • lot of cmake configuration and msbuild conditions
  • lot of conditional code in src/native/libs/System.Native/*
    • because WASI doesn't have nmap, threads, termio, process, signals, uuid, random, most of sockets ...
    • the changes are not trying to be perfect, this is to make it compile
  • minor changes to mono
  • moving files in src/mono/wasi folder and src/mono/samples/wasi
  • WASI SDK & wasmtime provisioning
  • compile only CI lane

out of scope, next PRs

  • any unit tests
  • trying to polyfill the gaps in POSIX layer
  • managed libraries correct annotation and PNSE

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono labels Nov 30, 2022
@pavelsavara pavelsavara added this to the 8.0.0 milestone Nov 30, 2022
@pavelsavara pavelsavara requested a review from radical November 30, 2022 17:02
@pavelsavara pavelsavara self-assigned this Nov 30, 2022
@ghost
Copy link

ghost commented Nov 30, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #65895

  • can compile mono+libs with WASI SDK
  • can run hello world sample with wasmtime
  • log of cmake configuration and msbuild conditions
  • lot of conditional code in src/native/libs/System.Native/*
    • because WASI doesn't have nmap, threads, termio, process, signals, uuid, random, most of sockets ...
  • minor changes to mono
  • moving files in src/mono/wasi folder and src/mono/samples/wasi
  • WASI SDK & wasmtime provisioning
  • compile only CI lane

out of scope, next PRs

  • any unit tests
  • trying to polyfill the gaps in POSIX layer
  • managed libraries correct annotation and PNSE
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-Build-mono
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

pavelsavara commented Nov 30, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 30, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Nov 30, 2022
Open
@build-analysis build-analysis bot mentioned this pull request Dec 1, 2022
Closed
marek-safar
marek-safar reviewed Dec 1, 2022
View reviewed changes
jkotas
jkotas reviewed Dec 1, 2022
View reviewed changes
@pavelsavara
Merge branch 'main' into wasi_native_prep
dd71877 
# Conflicts:
#	eng/targetingpacks.targets
#	src/libraries/System.IO.Compression/src/CompatibilitySuppressions.xml
#	src/libraries/System.Net.Http/src/System.Net.Http.csproj
#	src/libraries/System.Net.Primitives/src/CompatibilitySuppressions.xml
#	src/mono/wasi/sample/Directory.Build.props
#	src/mono/wasi/sample/console/Makefile
#	src/mono/wasi/sample/console/WasiConsoleApp/WasiConsoleApp.csproj
#	src/mono/wasi/sample/console/main.c
@pavelsavara
fix after merge
9b36c3b
@build-analysis build-analysis bot mentioned this pull request Dec 5, 2022
Open
2 tasks
@build-analysis build-analysis bot mentioned this pull request Dec 20, 2022
Closed
am11
am11 reviewed Dec 20, 2022
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Dec 21, 2022
Closed
@pavelsavara
Copy link
Member Author

pavelsavara commented Dec 21, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 21, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@runfoapp runfoapp bot mentioned this pull request Dec 27, 2022
Closed
kg
kg reviewed Jan 2, 2023
View reviewed changes
@pavelsavara
Merge branch 'main' into wasi_native_prep
b172a04 
# Conflicts:
#	src/libraries/System.Console/src/System.Console.csproj
#	src/libraries/System.IO.Compression/src/System.IO.Compression.csproj
#	src/libraries/System.Net.Http/src/System.Net.Http.csproj
#	src/libraries/System.Net.Primitives/src/System.Net.Primitives.csproj
@pavelsavara
feedback
edfe354
@build-analysis build-analysis bot mentioned this pull request Jan 3, 2023
Closed
@radical
Copy link
Member

radical commented Jan 3, 2023

Any remaining feedback here?

@pavelsavara pavelsavara changed the title [draft][wasi] compile with libs.native [wasi] compile with libs.native Jan 3, 2023
@vargaz
Copy link
Contributor

vargaz commented Jan 3, 2023

The mono changes look ok to me.

@radical
Copy link
Member

radical commented Jan 3, 2023

The WASI changes are WIP right now, and there is follow up work for that. As long as the non-wasi-specific changes are fine, we should merge this.

@pavelsavara
Merge branch 'main' into wasi_native_prep
f7f8cb9 
# Conflicts:
#	src/mono/System.Private.CoreLib/System.Private.CoreLib.csproj
#	src/mono/mono.proj
@pavelsavara
fix merge
3a273db
@pavelsavara
fix
c1b834d
@pavelsavara
Copy link
Member Author

pavelsavara commented Jan 6, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 6, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara merged commit f08d13f into dotnet:main Jan 7, 2023
@SingleAccretion SingleAccretion mentioned this pull request Jan 13, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2023
@pavelsavara pavelsavara deleted the wasi_native_prep branch September 2, 2024 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kg kg kg left review comments

@marek-safar marek-safar marek-safar left review comments

@akoeplinger akoeplinger akoeplinger left review comments

@jkotas jkotas jkotas left review comments

@radical radical radical approved these changes

@thaystg thaystg thaystg approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

+1 more reviewer

@am11 am11 am11 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@pavelsavara @radical @vargaz @kg @marek-safar @akoeplinger @am11 @thaystg @jkotas