Expose the IBinaryInteger<T>.ReadBig/LittleEndian APIs #73274
Conversation
…eadBigEndian APIs
…teger<T>.ReadBigEndian APIs
ghost
added
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis resolves #71902
|
src/libraries/System.Private.CoreLib/src/System/Numerics/IBinaryInteger.cs
Outdated
Show resolved
Hide resolved
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Numerics; |
There was a problem hiding this comment.
Not related to this PR, but we should rename this file at some point.
| return false; | ||
| } | ||
|
|
||
| if ((source.Length > sizeof(byte)) && (source[..^sizeof(byte)].IndexOfAnyExcept((byte)0x00) != -1)) |
There was a problem hiding this comment.
Maybe we should try to squeeze in some vectorization of IndexOfAnyExcept for .NET 7?
#67942
There was a problem hiding this comment.
Its not going to be "critical" for this API in .NET 7. I expect these ones will be more rarely used.
If we can manage it, then that will be a bonus :)
3 participants
This resolves #71902