You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change #65597 switching over JIT/Methodical tests to use merged wrappers has already
received extensive testing most of which works fine with the exception of r2r-extra runs. According
to my investigation it looks like the GCStress mode 0xF has a bug that got uncovered by the larger
merged test - in some cases the finalizer queue can end up in an infinite loop as the finalizations
keep adding more stuff on the finalizer queue. To prevent additional delays in merging in the
JIT/Methodical test merge I propose temporarily downgrading the GC stress level for these tests
to 0xC per Bruce's suggestion. I expect us to revert this change once the primary bug has been fixed.
Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.
Issue Details
The change #65597 switching over JIT/Methodical tests to use merged wrappers has already
received extensive testing most of which works fine with the exception of r2r-extra runs. According
to my investigation it looks like the GCStress mode 0xF has a bug that got uncovered by the larger
merged test - in some cases the finalizer queue can end up in an infinite loop as the finalizations
keep adding more stuff on the finalizer queue. To prevent additional delays in merging in the
JIT/Methodical test merge I propose temporarily downgrading the GC stress level for these tests
to 0xC per Bruce's suggestion. I expect us to revert this change once the primary bug has been fixed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
assigned
The change #65597 switching over JIT/Methodical tests to use merged wrappers has already
received extensive testing most of which works fine with the exception of r2r-extra runs. According
to my investigation it looks like the GCStress mode 0xF has a bug that got uncovered by the larger
merged test - in some cases the finalizer queue can end up in an infinite loop as the finalizations
keep adding more stuff on the finalizer queue. To prevent additional delays in merging in the
JIT/Methodical test merge I propose temporarily downgrading the GC stress level for these tests
to 0xC per Bruce's suggestion. I expect us to revert this change once the primary bug has been fixed.
Thanks
Tomas