Skip to content

Temporarily disable coredumps during library testing on macOS #63742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Temporarily disable coredumps during library testing on macOS #63742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea7e4c9
Temporarily disable coredumps during library testing on macOS
akoeplinger Jan 13, 2022
a03c672
Try again
akoeplinger Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/testing/RunnerTemplate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ if [[ "$(uname -s)" == "Darwin" ]]; then
# files already in /cores/ at this point. This is being done to prevent
# inadvertently flooding the CI machines with dumps.
if [[ ! -d "/cores" || ! "$(ls -A /cores)" ]]; then
ulimit -c unlimited
# FIXME: temporarily disable core dumps
Copy link
Member

@stephentoub stephentoub Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge this, please open an issue to track re-enabling it. Thanks!

Copy link
Member Author

@akoeplinger akoeplinger Jan 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah will do, just wanted to validate first that this actually works

Copy link
Member Author

@akoeplinger akoeplinger Jan 13, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, seems to work for the System.Runtime.InteropServices.Tests issue, but the PayloadGroup0 runtime test is also still running into it because it also sets ulimit.

I filed #63761 for tracking the issue.

ulimit -c 0
fi

elif [[ "$(uname -s)" == "Linux" ]]; then
Expand Down