JIT: fix issues with profile incorporation phase #47723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change dotnet#47646 did not remove the code in `fgMakeBasicBlocks` that set profile data. That masked some flaws in `fgIncorporateProfileData`: * it should process all blocks; nothing has been imported yet * it must honor a constraint that some handler blocks can't be rare. This fixes the above, and removes the early profile setting.
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
cc @dotnet/jit-contrib No diffs per SPMI (which includes PGO runs in crossgen). Verified locally dynamic PGO still happy. The artificial profile counts on handler entries lead to some code bloat we might want to avoid. Per SPMI impact is small, so not a high priority. Note there were some regressions too, my guess is those are cases where it can pay off to inline small methods in cold blocks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change #47646 did not remove the code in
fgMakeBasicBlocksthat set profiledata. That masked some flaws in
fgIncorporateProfileData:This fixes the above, and removes the early profile setting.