Fix interpreter jmp to pinvoke #121329
Merged
Fix interpreter jmp to pinvoke #121329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interpreter compiler ignores tail call prefix for tail calls (and jmp) to pinvokes that are not marshalled. But it is not injecting "ret" IR opcode after the call returns, which results in BADCODE reported by the compiler. There are several coreclr tests in the JIT/jit64/mcc/interop that fail due to that. This change adds injecting proper form of "ret" IR opcode after such calls.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where tail calls to PInvoke methods (which are not marshaled) are incorrectly handled in the interpreter compiler. Since PInvokes are not IL code, they cannot be tail-called directly. The PR converts such tail calls to normal calls followed by an injected return instruction to preserve the intended semantics.
- Adds logic to detect when a tail call target is a non-marshaled PInvoke and converts it to a normal call
- Injects appropriate return instructions after the call based on the return type
janvorli
changed the title
davidwrighton
approved these changes
Nov 4, 2025
This was referenced Nov 4, 2025
Open
Member
Author
|
/ba-g the android timeout is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter compiler ignores tail call prefix for tail calls (and jmp) to pinvokes that are not marshalled. But it is not injecting "ret" IR opcode after the call returns, which results in BADCODE reported by the compiler.
There are several coreclr tests in the JIT/jit64/mcc/interop that fail due to that.
This change adds injecting proper form of "ret" IR opcode after such calls.