Skip to content

Conversation

@amanasifkhalid
Copy link
Contributor

While removing the old block layout code, I noticed return merging has a step for moving return blocks up to their ideal predecessors to make up for deficiencies in block reordering that no longer exist. Removing this step adds jumps to newly added return blocks in MinOpts, and incurs a few diffs from fgUpdateFlowGraph churn in FullOpts; both seem acceptable.

Copilot AI review requested due to automatic review settings March 7, 2025 21:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 7, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Contributor Author

Since we limit the number of epilogues to 4 at the moment, the TP cost of emitting additional branches due to the loss of fallthrough in MinOpts exceeds the TP gain from not moving the return blocks up to their successors. It's not worth pursuing this now, but it's worth reconsidering if we ever increase the number of epilogues allowed.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant