-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[main] Update dependencies from 7 repositories #108636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from 7 repositories #108636
Conversation
Microsoft.DotNet.ApiCompat.Task From Version 10.0.100-alpha.1.24480.5 -> To Version 10.0.100-alpha.1.24507.16
…nals build 20241007.2 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 10.0.0-alpha.1.24502.3 -> To Version 10.0.0-alpha.1.24507.2
Microsoft.NETCore.Runtime.ICU.Transport From Version 10.0.0-alpha.1.24503.1 -> To Version 10.0.0-alpha.1.24507.2
…ld 20241007.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 10.0.0-beta.24480.2 -> To Version 10.0.0-beta.24507.1
…ild 20241007.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 10.0.0-alpha.0.24480.1 -> To Version 10.0.0-alpha.0.24507.1
Microsoft.NETCore.Runtime.ICU.Transport From Version 10.0.0-alpha.1.24507.2 -> To Version 10.0.0-alpha.1.24510.1
…ld 20241010.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 10.0.0-beta.24507.1 -> To Version 10.0.0-beta.24510.1
…ild 20241010.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 10.0.0-alpha.0.24507.1 -> To Version 10.0.0-alpha.0.24510.1
…10.1 Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil From Version 0.11.5-alpha.24480.1 -> To Version 0.11.5-alpha.24510.1
…nals build 20241011.4 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 10.0.0-alpha.1.24507.2 -> To Version 10.0.0-alpha.1.24511.4
It appears to happen when ilasm flows (I reproduced it locally), but the "corrupt" DLL files are not corrupt according to peverify, ilverify, ilspy, or ildasm. It seems like it might be a latent bug in the IL verifier in coreclr (that is only enabled in checked builds). I'm not sure why ilasm's behavior changed though, I've verified manually that none of the new behavior I added should be engaged (it's off by default). |
|
Should I undo the flowing of IL SDK and ilasm for now? It's beyond me how it's broken, but it would unblock flow for now. I think the verifier is what needs to be fixed, since nothing seems to be wrong with the generated DLLs. |
…1021.1 Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 10.0.0-alpha.1.24517.1 -> To Version 10.0.0-alpha.1.24521.1
Microsoft.DotNet.ApiCompat.Task From Version 10.0.100-alpha.1.24480.5 -> To Version 10.0.100-alpha.1.24510.13
|
The check failure causing the mcc_i tests to fail in checked lanes is in I'm still not certain these DLLs are actually corrupt but this at least narrows down what coreclr (in checked mode only) dislikes about them. |
|
The corrupt DLL appears to have a malformed imports section somehow. Comparing a malformed ilasm output with a BCL dll using dumpbin: |
|
ilasm is broken because when it does: if (FAILED(hr=m_pEmitter->GetSaveSize(cssAccurate, &metaDataSize))) goto exit;it gets a if (FAILED(hr=m_pCeeFileGen->EmitMetaDataAt(m_pCeeFile, m_pEmitter, m_pILSection, metaDataOffset, metaData, metaDataSize))) goto exit;
This points to We can unblock flow temporarily by not flowing ilasm, but ilasm (well, its dependency) is just actually busted and the next time it flows it will break again. |
This should fix the System.BadImageFormatException failures in #108636 that were being caused by ilasm producing malformed DLLs in some cases.
Microsoft.NETCore.Runtime.ICU.Transport From Version 10.0.0-alpha.1.24514.3 -> To Version 10.0.0-alpha.1.24521.2
…21.1 Microsoft.SourceBuild.Intermediate.cecil , Microsoft.DotNet.Cecil From Version 0.11.5-alpha.24515.1 -> To Version 0.11.5-alpha.24521.1
…ld 20241021.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 10.0.0-beta.24514.1 -> To Version 10.0.0-beta.24521.1
…nals build 20241021.1 Microsoft.SourceBuild.Intermediate.source-build-externals From Version 10.0.0-alpha.1.24516.1 -> To Version 10.0.0-alpha.1.24521.1
…1021.2 Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 10.0.0-alpha.1.24521.1 -> To Version 10.0.0-alpha.1.24521.2
…1022.5 Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Reflection.Metadata , System.Reflection.MetadataLoadContext , System.Text.Json , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 10.0.0-alpha.1.24521.2 -> To Version 10.0.0-alpha.1.24522.5
This pull request updates the following dependencies
From https://github.com/dotnet/sdk
From https://github.com/dotnet/source-build-externals
From https://github.com/dotnet/icu
From https://github.com/dotnet/runtime-assets
From https://github.com/dotnet/hotreload-utils
From https://github.com/dotnet/cecil
From https://github.com/dotnet/runtime
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format