Remove static monitor helper functions #107667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidwrighton
commented
Sep 11, 2024
davidwrighton
commented
- Replace them with using the normal monitor helpers
- Change CORINFO_HELP_GETSYNCFROMCLASSHANDLE to return an objec instead of the underlying lock object, implementation of the JIT helper can be shared with other Typehandle to RuntimeType scenarios
- This will likely improve the performance of synchronized methods, but that is beside the point, since this feature is so rarely used
- Replace them with using the normal monitor helpers - Change CORINFO_HELP_GETSYNCFROMCLASSHANDLE to return an objec instead of the underlying lock object, implementation of the JIT helper can be shared with other Typehandle to RuntimeType scenarios - This will likely improve the performance of synchronized methods, but that is beside the point, since this feature is so rarely used
ghost
added
the
needs-area-label
3 tasks
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
NativeAOT part LGTM otherwise, thanks for the simplification!
src/coreclr/tools/aot/ILCompiler.Compiler/IL/ILImporter.Scanner.cs
Outdated
Show resolved
Hide resolved
davidwrighton
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
JulieLeeMSFT
removed
the
needs-area-label
Member
|
@jakobbotsch, PTAL. |
jakobbotsch
approved these changes
Oct 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.