[WASI] fix response header conversion and event loop #107162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses two issues: - In `WasiHttpHandler`, we were setting `response.Content` after calling `WasiHttpInterop.ConvertResponseHeaders`, which had the effect of removing any content headers we had previously added. The fix is to call `WasiHttpInterop.ConvertResponseHeaders` _after_ setting `response.Content`. - In `WasiEventLoop`, we were calling `wasi:io/poll#poll` regardless of whether any tasks had been canceled during the call to `ThreadPoolWorkQueue.Dispatch`. That meant the application was not given a chance to quit the event loop promptly, e.g. when tasks are still pending, but the the task(s) the app actually _cares_ about have completed. The fix is to return without polling if we detect one or more tasks have been canceled. The app can always keep looping if it's not ready to exit. Signed-off-by: Joel Dice <[email protected]>
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
campersau
reviewed
Aug 30, 2024
src/libraries/System.Net.Http/src/System/Net/Http/WasiHttpHandler/WasiHttpHandler.cs
Show resolved
Hide resolved
…ler/WasiHttpHandler.cs Co-authored-by: campersau <[email protected]>
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
approved these changes
Aug 30, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
Co-authored-by: campersau <[email protected]> Co-authored-by: Pavel Savara <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two issues:
In
WasiHttpHandler, we were settingresponse.Contentafter callingWasiHttpInterop.ConvertResponseHeaders, which had the effect of removing any content headers we had previously added. The fix is to callWasiHttpInterop.ConvertResponseHeadersafter settingresponse.Content.In
WasiEventLoop, we were callingwasi:io/poll#pollregardless of whether any tasks had been canceled during the call toThreadPoolWorkQueue.Dispatch. That meant the application was not given a chance to quit the event loop promptly, e.g. when tasks are still pending, but the the task(s) the app actually cares about have completed. The fix is to return without polling if we detect one or more tasks have been canceled. The app can always keep looping if it's not ready to exit.