Skip to content

Conversation

@kant2002
Copy link
Contributor

No description provided.

@ghost ghost added the area-System.Numerics label Apr 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 17, 2024
@danmoseley
Copy link
Member

Does this need a matching test or test change?

@kant2002
Copy link
Contributor Author

I don't see any tests infrastructure for these formatting. it fails in rare case

short yyy = 2047;
var h = *((Half*)(short*)&yyy);  // this is only to simulate specific number.
var s = (h).ToString("F24");
Console.WriteLine("{0}", s); 

actual number is in the comment.

@kant2002
Copy link
Contributor Author

Seems to be this is fixed #100187 ?

@tannergooding
Copy link
Member

Yes, this should already be resolved with #100187 and there should be no remaining failure cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Numerics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants