[API Proposal]: public ctor for CookieException with string parameter

[mateusz-dobrowolny]

Background and motivation

CDD - Cookie Driven Development

API Proposal

namespace System.Net
{
    [Serializable]
    [...]
    
    public class CookieException : FormatException, ISerializable
    {
        public CookieException() : base()
        {
        }

        // Please make this public
        public CookieException(string? message) : base(message)
        {
        }

Please change access modifier for ctor with string? to public.

API Usage

throw new CookieException("🥮");
throw new CookieException("🍥");
throw new CookieException("🍪");
throw new CookieException("🍩");
throw new CookieException("🍰");

Alternative Designs

Alternatively make it protected, so I still can initialize CookieException with particular cookie.

Risks

Instance of CookieMonster may appear unexpectedly.

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Background and motivation

CDD - Cookie Driven Development

API Proposal

namespace System.Net
{
    [Serializable]
    [...]
    
    public class CookieException : FormatException, ISerializable
    {
        public CookieException() : base()
        {
        }

        // Please make this public
        public CookieException(string? message) : base(message)
        {
        }

Please change access modifier for ctor with string? to public.

API Usage

throw new CookieException("🥮");
throw new CookieException("🍥");
throw new CookieException("🍪");
throw new CookieException("🍩");
throw new CookieException("🍰");

Alternative Designs

Alternatively make it protected, so I still can initialize CookieException with particular cookie.

Risks

Instance of CookieMonster may appear unexpectedly.

Author:	mateusz-dobrowolny
Assignees:	-
Labels:	api-suggestion, area-System.Net, untriaged
Milestone:	-

[antonfirsov]

Personally I would be fine with this, and it looks like a trivial addition. Most BCL exception constructors allow passing a message string, it's CookieException that seems to be exceptional in this sense.

@dotnet/ncl any objections against marking this ready for review?

[antonfirsov]

Triage: assigned to Future given it's not critical. Once the API is approved, we can mark it help wanted, since it's a good candidate for community contribution.

[terrajobst]

Video

• We should also add the one that takes inner exceptions, for consistency with other exceptions

namespace System.Net;

public partial class CookieException
{
    // Existing ctors:
    // public CookieException();
    // public CookieException(SerializationInfo, StreamingContext);
    public CookieException(string? message);
    public CookieException(string? message, Exception? innerException);
 }