JIT\opt\OSR\tailrecursetry\tailrecursetry.cmd fails with COMPlus_FastTailCalls=0

[erozenfeld]

COMPlus_FastTailCalls is a new environment variable added in #341. When it's set to 0, all tail-prefixed calls are dispatched via helpers.

JIT\opt\OSR\tailrecursetry\tailrecursetry.cmd is a test that turns on on-stack replacement, it sets

set COMPlus_TieredCompilation=1
set COMPlus_TC_QuickJitForLoops=1
set COMPlus_TC_OnStackReplacement=1

If additionally we set

set COMPlus_FastTailCalls=0

the test fails with

BEGIN EXECUTION
 "f:\runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked\Tests\Core_Root\corerun.exe" tailrecursetry.dll
starting sum

Assert failure(PID 1896 [0x00000768], Thread: 49832 [0xc2a8]): Assertion failed 'phiFound' in 'TailRecursionWithOsrEntryInTry:F(int,int,int,int):int' during 'SSA: insert phis' (IL size 49)

    File: F:\runtime\src\coreclr\src\jit\ssabuilder.cpp Line: 922
    Image: f:\runtime\artifacts\tests\coreclr\Windows_NT.x64.Checked\Tests\Core_Root\CoreRun.exe

Expected: 100
Actual: -1073740286
END EXECUTION - FAILED
FAILED

category:correctness
theme:osr
skill-level:expert
cost:medium

[erozenfeld]

@dotnet/jit-contrib @AndyAyersMS

[AndyAyersMS]

Pre-SSA liveness deletes the assignment to the catch variable, and things go downhill from there.

Removing statement STMT00009 (IL 0x014...0x015)
N003 (  5,  4) [000046] -A---O--R---              *  ASG       ref   
N002 (  3,  2) [000045] D------N----              +--*  LCL_VAR   ref    V08 tmp1         
N001 (  1,  1) [000011] -----O------              \--*  CATCH_ARG ref   
 in BB08 as useless:

BB08 becomes empty

[AndyAyersMS]

Actually that part is OK, the issue is that upstream we're not getting the expected dominance frontier for the catch block.

[AndyAyersMS]

Looks like a similar issue to what I saw over with #34522 -- there are more places in the jit where we assume the try region entry is the first try.

In this test case we normally change the recursive tail call into a jump. In order to make that work with OSR we import the method entry block and mark it as must keep, since it will otherwise be unreferenced until morph does the call -> jump transformation. Importing this block may pull in other blocks that OSR normally wouldn't import.

We don't do that transformation when COMPlus_FastTailCalls=0, but we still have the additional block(s) we imported in anticipation that we might do the transformation. These blocks are unreachable but the ones marked as keep remain around. And in this case we end up with a try region where the first block of the try is unreachable and empty but is still there in the flow graph.

Just before building SSA we have we have a try region BB03-BB04 where BB03 is empty and unreachable and the try entry is BB04.

-----------------------------------------------------------------------------------------------------------------------------------------
BBnum BBid ref try hnd preds           weight    lp [IL range]     [jump]      [EH region]         [flags]
-----------------------------------------------------------------------------------------------------------------------------------------
BB01 [0009]  1                             1        [???..???)-> BB04 (always)                     i internal label target 
BB02 [0000]  0                             0        [000..002)        (throw )                     keep i rare bwd bwd-target 
BB03 [0001]  0  0                          0        [002..006)        (throw ) T0      try {       keep i try rare label bwd 
BB04 [0002]  2  0    BB01,BB04             8        [006..012)-> BB04 ( cond ) T0      }           i Loop label target bwd bwd-target 
BB05 [0006]  2       BB04,BB08             1        [017..01B)-> BB07 ( cond )                     i label target bwd 
BB06 [0007]  1       BB05                  1        [01B..01D)        (return)                     i bwd 
BB07 [0008]  1       BB05                  1        [01D..031)        (return)                     i label target gcsafe bwd 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ funclets follow
BB08 [0005]  1     0                       0        [014..017)-> BB05 ( cret )    H0 F catch { }   keep i rare label target flet bwd 

This breaks an assumption in BlockPredsWithEH that the first block of the try is the try entry, and so it predecessors are potentially also predecessors to any handler block for the try. Because of this we fail to put a PHI into BB08 for V04, and hence the assert.

Fixing that in a manner similar to the fix in #34522 (search the try region for the entry) gets us a bit further as we insert the PHI, but we then hit another assert as the PHI is degenerate and has only one input.

Now the issue is that when building SSA we hit a similar assumption in AddPhiArgsToSuccessors. This time we're outside the try and need to decide if we should add the current defs to handler successors of the block, and we fail to realize that BB01 needs to add its def of V04 to the BB08 phi, because BB01's successor BB04 is in a try but is not the first block of the try.

So it looks like there are now at least 3 places where the jit assumes that the first block of the try is the try entry. Instead of trying to fix these (and possibly more) I'm going to see if we can prune away the unreachable blocks so that the OSR cases continue to follow the expected form for trys.

[AndyAyersMS]

I'm going to see if we can prune away the unreachable blocks

Have part of this fixed -- the jit is now is able to get rid of BB02 in the above; instead of protecting it with a bbflag I can protect it by manipulating reference counts. This approach is needed because once you set BBF_DONT_REMOVE it is effectively impossible to unset.

Getting rid of BB03 is going to be a bit harder; there is a lot of bias in the code expecting that try region entry blocks are are untouchable and come first in the region. Likely what we'll need is to do something akin to the region entry trimming I added when OSR was first introduced, but this version of try region trimming must run later, and is only needed if we imported the original method entry, and then morph decides not to introduce branches to the original entry.

The logic should be something like: check to see if the entry block successor is in a try region, and if so, if that block is not the first block of the try, move it so it is the first block in the try. Need to ensure this is workable when the entry block successor is in multiple trys.

[AndyAyersMS]

May also need to watch out for #6892.

[AndyAyersMS]

Well, figuring out the right thing here is looking more complex than I'd like; we may need to support the idea that a try region entry is not always the first block in the try.

Since this case seemingly only happens if:

• The OSR entry is point in a try; and
• The method hast tail recursive call

I think I should to just disable the tail recursion to loop opt in the above case for now, so things are at least correct, and defer further work. We can still tail call.

[erozenfeld]

I think I should to just disable the tail recursion to loop opt in the above case for now, so things are at least correct, and defer further work. We can still tail call.

I'm confused. The test fails with "set COMPlus_FastTailCalls=0", which also disables tail recursion to loop opt. What am I missing?

[AndyAyersMS]

To support tail recursion->loop in OSR we over-import; if the optimization doesn't happen, we're left with unreachable code that is hard to properly clean up when it involves try regions. The unreachable code leads to confusion when enumerating EH preds and building SSA.

COMPlus_FastTailCalls=0 disables the optimization and so is an enabler here; normally we can do tail recursion -> loop with few restrictions so we don't hit this problem. There are likely examples where we could make OSR fail without this complus setting.

[erozenfeld]

I think I understand now. Your proposal is to both disable tail recursion to loop opt and to stop over-importing if the two bullets above are true. That makes sense.