Avoid double Dictionary lookups (incl. hashkey generation) by using new Dictionary methods (#120456)

Henr1k80 · web-flow · commit ff8bbb91c39c · 2025-10-07T07:19:30.000-07:00
diff --git a/src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs b/src/coreclr/System.Private.CoreLib/src/System/RuntimeType.CoreCLR.cs
@@ -1177,10 +1177,8 @@ private void PopulateEvents(
                         {
                             string name = eventInfo.Name;
 
-                            if (csEventInfos.ContainsKey(name))
+                            if (!csEventInfos.TryAdd(name, eventInfo))
                                 continue;
-
-                            csEventInfos[name] = eventInfo;
                         }
                         else
                         {
diff --git a/src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/Compiler.cs b/src/libraries/System.Private.Xml/src/System/Xml/Xsl/Xslt/Compiler.cs
@@ -96,10 +96,7 @@ public Stylesheet CreateStylesheet()
 
         public void AddModule(string baseUri)
         {
-            if (!_moduleOrder.ContainsKey(baseUri))
-            {
-                _moduleOrder[baseUri] = _moduleOrder.Count;
-            }
+            _moduleOrder.TryAdd(baseUri, _moduleOrder.Count);
         }
 
         public void ApplyNsAliases(ref string? prefix, ref string nsUri)

Original file line number	Diff line number	Diff line change
`@@ -1177,10 +1177,8 @@ private void PopulateEvents(`
`1177`	`1177`	`{`
`1178`	`1178`	`string name = eventInfo.Name;`
`1179`	`1179`
`1180`		`- if (csEventInfos.ContainsKey(name))`
	`1180`	`+ if (!csEventInfos.TryAdd(name, eventInfo))`
`1181`	`1181`	`continue;`
`1182`		`-`
`1183`		`- csEventInfos[name] = eventInfo;`
`1184`	`1182`	`}`
`1185`	`1183`	`else`
`1186`	`1184`	`{`
Original file line number	Diff line number	Diff line change
`@@ -96,10 +96,7 @@ public Stylesheet CreateStylesheet()`
`96`	`96`
`97`	`97`	`public void AddModule(string baseUri)`
`98`	`98`	`{`
`99`		`- if (!_moduleOrder.ContainsKey(baseUri))`
`100`		`- {`
`101`		`- _moduleOrder[baseUri] = _moduleOrder.Count;`
`102`		`- }`
	`99`	`+ _moduleOrder.TryAdd(baseUri, _moduleOrder.Count);`
`103`	`100`	`}`
`104`	`101`
`105`	`102`	`public void ApplyNsAliases(ref string? prefix, ref string nsUri)`