[System.DirectoryServices.Protocols] Fix ProtocolVersion Overflow on Big Endian Systems (#112391)

medhatiwari · web-flow · commit d086ec6d86a8 · 2025-02-18T09:53:34.000-06:00
diff --git a/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Linux.cs b/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Linux.cs
@@ -55,12 +55,6 @@ public bool SecureSocketLayer
             }
         }
 
-        public int ProtocolVersion
-        {
-            get => GetPtrValueHelper(LdapOption.LDAP_OPT_VERSION).ToInt32();
-            set => SetPtrValueHelper(LdapOption.LDAP_OPT_VERSION, new IntPtr(value));
-        }
-
         public ReferralChasingOptions ReferralChasing
         {
             get
diff --git a/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Windows.cs b/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.Windows.cs
@@ -34,12 +34,6 @@ public bool SecureSocketLayer
         [UnsupportedOSPlatform("windows")]
         public void StartNewTlsSessionContext() => throw new PlatformNotSupportedException();
 
-        public int ProtocolVersion
-        {
-            get => GetIntValueHelper(LdapOption.LDAP_OPT_VERSION);
-            set => SetIntValueHelper(LdapOption.LDAP_OPT_VERSION, value);
-        }
-
         public ReferralChasingOptions ReferralChasing
         {
             get
diff --git a/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.cs b/src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapSessionOptions.cs
@@ -757,6 +757,12 @@ public void StopTransportLayerSecurity()
             }
         }
 
+        public int ProtocolVersion
+        {
+            get => GetIntValueHelper(LdapOption.LDAP_OPT_VERSION);
+            set => SetIntValueHelper(LdapOption.LDAP_OPT_VERSION, value);
+        }
+
         private int GetIntValueHelper(LdapOption option)
         {
             if (_connection._disposed)

Original file line number	Diff line number	Diff line change
`@@ -55,12 +55,6 @@ public bool SecureSocketLayer`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`
`58`		`- public int ProtocolVersion`
`59`		`- {`
`60`		`- get => GetPtrValueHelper(LdapOption.LDAP_OPT_VERSION).ToInt32();`
`61`		`- set => SetPtrValueHelper(LdapOption.LDAP_OPT_VERSION, new IntPtr(value));`
`62`		`- }`
`63`		`-`
`64`	`58`	`public ReferralChasingOptions ReferralChasing`
`65`	`59`	`{`
`66`	`60`	`get`
Original file line number	Diff line number	Diff line change
`@@ -757,6 +757,12 @@ public void StopTransportLayerSecurity()`
`757`	`757`	`}`
`758`	`758`	`}`
`759`	`759`
	`760`	`+ public int ProtocolVersion`
	`761`	`+ {`
	`762`	`+ get => GetIntValueHelper(LdapOption.LDAP_OPT_VERSION);`
	`763`	`+ set => SetIntValueHelper(LdapOption.LDAP_OPT_VERSION, value);`
	`764`	`+ }`
	`765`	`+`
`760`	`766`	`private int GetIntValueHelper(LdapOption option)`
`761`	`767`	`{`
`762`	`768`	`if (_connection._disposed)`