Replace Debug.Assert(false, with Debug.Fail(

Author: stephentoub

src/coreclr/nativeaot/Common/src/Internal/Runtime/MethodTable.cs

@@ -1362,7 +1362,7 @@ public uint GetFieldOffset(EETypeField eField)
                 return cbOffset;
             }
 
-            Debug.Assert(false, "Unknown MethodTable field type");
+            Debug.Fail("Unknown MethodTable field type");
             return 0;
         }
 

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/ExceptionHandling.cs

@@ -200,7 +200,7 @@ private static void OnUnhandledExceptionViaClassLib(object exception)
                 // disallow all exceptions leaking out of callbacks
             }
 #else
-            Debug.Assert(false, "Unhandled exceptions should be processed by the native runtime only");
+            Debug.Fail("Unhandled exceptions should be processed by the native runtime only");
 #endif
         }
 
@@ -429,7 +429,7 @@ public static Exception GetRuntimeException(ExceptionIDs id)
                     return new InvalidCastException();
 
                 default:
-                    Debug.Assert(false, "unexpected ExceptionID");
+                    Debug.Fail("unexpected ExceptionID");
                     FallbackFailFast(RhFailFastReason.InternalError, null);
                     return null;
             }
@@ -696,7 +696,7 @@ public static void RhUnwindAndIntercept(ref ExInfo exInfo, UIntPtr interceptStac
                 InternalCalls.ResumeAtInterceptionLocation(exInfo._frameIter.RegisterSet);
             }
 
-            Debug.Assert(false, "unreachable");
+            Debug.Fail("unreachable");
             FallbackFailFast(RhFailFastReason.InternalError, null);
         }
 #endif // !NATIVEAOT
@@ -903,7 +903,7 @@ private static void DispatchEx(scoped ref StackFrameIterator frameIter, ref ExIn
                     pReversePInvokePropagationContext, pReversePInvokePropagationCallback, frameIter.RegisterSet, ref exInfo, frameIter.PreviousTransitionFrame);
                 // the helper should jump to propagation handler and not return
 #endif
-                Debug.Assert(false, "unreachable");
+                Debug.Fail("unreachable");
                 FallbackFailFast(RhFailFastReason.InternalError, null);
             }
 #endif // FEATURE_OBJCMARSHAL
@@ -926,7 +926,7 @@ private static void DispatchEx(scoped ref StackFrameIterator frameIter, ref ExIn
             }
 #endif // NATIVEAOT
             // currently, RhpCallCatchFunclet will resume after the catch
-            Debug.Assert(false, "unreachable");
+            Debug.Fail("unreachable");
             FallbackFailFast(RhFailFastReason.InternalError, null);
         }
 

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/RuntimeExports.cs

@@ -388,7 +388,7 @@ internal static unsafe IntPtr RhGetRuntimeHelperForType(MethodTable* pEEType, Ru
                     return (IntPtr)(delegate*<MethodTable*, int, object>)&InternalCalls.RhpNewArray;
 
                 default:
-                    Debug.Assert(false, "Unknown RuntimeHelperKind");
+                    Debug.Fail("Unknown RuntimeHelperKind");
                     return IntPtr.Zero;
             }
         }

src/coreclr/nativeaot/Runtime.Base/src/System/Runtime/TypeCast.cs

@@ -711,7 +711,7 @@ internal static unsafe bool TypeParametersAreCompatible(int arity,
                         break;
 
                     default:
-                        Debug.Assert(false, "unknown generic variance type");
+                        Debug.Fail("unknown generic variance type");
                         break;
                 }
             }

src/coreclr/nativeaot/System.Private.StackTraceMetadata/src/Internal/StackTraceMetadata/MethodNameFormatter.cs

@@ -263,7 +263,7 @@ private void EmitTypeName(Handle typeHandle, Flags flags)
                     break;
 
                 default:
-                    Debug.Assert(false, $"Type handle {typeHandle.HandleType} was not handled");
+                    Debug.Fail($"Type handle {typeHandle.HandleType} was not handled");
                     _outputBuilder.Append("???");
                     break;
             }

src/coreclr/nativeaot/Test.CoreLib/src/System/RuntimeExceptionHelpers.cs

@@ -69,7 +69,7 @@ public static Exception GetRuntimeException(ExceptionIDs id)
                         return new PlatformNotSupportedException();
 
                     default:
-                        Debug.Assert(false, "unexpected ExceptionID");
+                        Debug.Fail("unexpected ExceptionID");
                         RuntimeImports.RhpFallbackFailFast();
                         return null;
                 }

src/coreclr/tools/Common/JitInterface/SystemVStructClassificator.cs

@@ -260,7 +260,7 @@ private static bool ClassifyEightBytes(TypeDesc typeDesc,
                 // The field can't span past the end of the struct.
                 if ((normalizedFieldOffset + fieldSize) > helper.StructSize)
                 {
-                    Debug.Assert(false, "Invalid struct size. The size of fields and overall size don't agree");
+                    Debug.Fail("Invalid struct size. The size of fields and overall size don't agree");
                     return false;
                 }
 

src/coreclr/tools/Common/TypeSystem/Common/FieldLayoutIntervalCalculator.cs

@@ -73,7 +73,7 @@ private int GetFieldSize(TypeDesc fieldType)
             }
             else
             {
-                Debug.Assert(false, fieldType.ToString());
+                Debug.Fail(fieldType.ToString());
                 return fieldType.GetElementSize().AsInt;
             }
         }

src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/Dataflow/CompilerGeneratedState.cs

@@ -378,7 +378,7 @@ void MapGeneratedTypeTypeParameters(
                                     }
                                     else
                                     {
-                                        Debug.Assert(false, "This should be impossible in valid code");
+                                        Debug.Fail("This should be impossible in valid code");
                                     }
                                 }
                             }

src/coreclr/tools/aot/ILCompiler.MetadataTransform/ILCompiler/Metadata/Transform.TypeForwarders.cs

@@ -39,7 +39,7 @@ private void HandleTypeForwarders(Cts.Ecma.EcmaModule module)
                 }
                 else
                 {
-                    Debug.Assert(false, "Multi-module assemblies");
+                    Debug.Fail("Multi-module assemblies");
                 }
             }
         }