Skip to content

Commit b83186a

Browse files
authored
[tests] InstallWorkloadFromArtifacts: handle a stable band version (#102533)
If the sdk band version is like `8.0.100` (stable, no with no preview/ci/dev suffixes), `bandPreleaseVersion`: `string bandPreleaseVersion = bandVersionRegex().Match(bandVersion).Groups[1].Value;` .. is `""` which breaks: ` bandVersion = bandVersion.Replace (bandPreleaseVersion, packagePreleaseVersion);` ``` System.ArgumentException: The value cannot be an empty string. (Parameter 'oldValue') at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName) at System.String.Replace(String oldValue, String newValue) at Microsoft.Workload.Build.Tasks.InstallWorkloadFromArtifacts.InstallWorkloadManifest(ITaskItem workloadId, Strin at Microsoft.Workload.Build.Tasks.InstallWorkloadFromArtifacts.InstallAllManifests() at Microsoft.Workload.Build.Tasks.InstallWorkloadFromArtifacts.Execute() at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingCo ``` This adds a null/empty string check on the local.
1 parent 3e2b6eb commit b83186a

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/tasks/WorkloadBuildTasks/InstallWorkloadFromArtifacts.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,8 +292,13 @@ private bool InstallWorkloadManifest(ITaskItem workloadId, string name, string v
292292
string packagePreleaseVersion = bandVersionRegex().Match(version).Groups[1].Value;
293293
string bandPreleaseVersion = bandVersionRegex().Match(bandVersion).Groups[1].Value;
294294

295-
if (packagePreleaseVersion != bandPreleaseVersion && packagePreleaseVersion != "-dev" && packagePreleaseVersion != "-ci")
295+
if (!string.IsNullOrEmpty(bandPreleaseVersion) &&
296+
packagePreleaseVersion != bandPreleaseVersion &&
297+
packagePreleaseVersion != "-dev" &&
298+
packagePreleaseVersion != "-ci")
299+
{
296300
bandVersion = bandVersion.Replace (bandPreleaseVersion, packagePreleaseVersion);
301+
}
297302

298303
PackageReference pkgRef = new(Name: $"{name}.Manifest-{bandVersion}",
299304
Version: version,

0 commit comments

Comments
 (0)