Skip to content

Commit b45b9a5

Browse files
committed
more
1 parent a7a3bd0 commit b45b9a5

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

src/coreclr/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@ if(NOT CLR_CROSS_COMPONENTS_BUILD AND NOT CLR_CMAKE_TARGET_MACCATALYST AND NOT C
6969
add_dependencies(runtime singlefilehost)
7070
else()
7171
if(CLR_CMAKE_TARGET_BROWSER)
72-
# TODOWASM set GEN_PINVOKE to 1 once we generate them. static entrypoint.c prevents C linker from trimming, when IL trimming trims PInvokes
72+
# WASM-TODO set GEN_PINVOKE to 1 once we generate them. static entrypoint.c prevents C linker from trimming, when IL trimming trims PInvokes
7373
set(GEN_PINVOKE 0)
74-
# TODOWASM should we start using System.Native.Browser and System.Runtime.InteropServices.JavaScript.Native also for Mono ?
74+
# WASM-TODO should we start using System.Native.Browser and System.Runtime.InteropServices.JavaScript.Native also for Mono ?
7575
set(BUILD_LIBS_NATIVE_BROWSER 1)
7676
add_subdirectory(${CLR_SRC_NATIVE_DIR}/corehost browserhost)
7777
add_dependencies(runtime browserhost)

src/native/corehost/browserhost/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ target_link_libraries(
7878
${END_WHOLE_ARCHIVE}
7979
)
8080

81-
# TODOWASM: this is temporary locations
81+
# WASM-TODO: this is temporary locations
8282
set(SAMPLE_ASSETS
8383
sample/index.html
8484
sample/main.mjs

src/native/corehost/browserhost/browserhost.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ static pal::char_t buffer[STRING_LENGTH("0xffffffffffffffff")];
108108

109109
extern "C" int browserHostInitializeCoreCLR(void)
110110
{
111-
//TODOWASM: does getenv return UTF8 ?
111+
//WASM-TODO: does getenv return UTF8 ?
112112
pal::getenv(HOST_PROPERTY_APP_PATHS, &app_path);
113113
pal::getenv(HOST_PROPERTY_NATIVE_DLL_SEARCH_DIRECTORIES, &search_paths);
114114
pal::getenv(HOST_PROPERTY_TRUSTED_PLATFORM_ASSEMBLIES, &tpa);
@@ -142,7 +142,7 @@ extern "C" int browserHostInitializeCoreCLR(void)
142142
return 0;
143143
}
144144

145-
// TODOWASM: browser needs async entrypoint
145+
// WASM-TODO: browser needs async entrypoint
146146
extern "C" int browserHostExecuteAssembly(const char* assemblyPath)
147147
{
148148
int exit_code;
@@ -162,11 +162,11 @@ extern "C" int browserHostExecuteAssembly(const char* assemblyPath)
162162
{
163163
std::fprintf(stderr, "coreclr_shutdown_2 failed - Error: 0x%08x\n", retval);
164164
exit_code = -1;
165-
// TODOWASM: this is too trivial
165+
// WASM-TODO: this is too trivial
166166
browserHostRejectMain("coreclr_shutdown_2 failed");
167167
}
168168

169-
// TODOWASM: this is too trivial
169+
// WASM-TODO: this is too trivial
170170
// because nothing runs continuations yet and also coreclr_execute_assembly is sync looping
171171
browserHostResolveMain(exit_code);
172172
return retval;

src/native/corehost/browserhost/loader/bootstrap.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ const nativeModulePromiseController = createPromiseController<EmscriptenModuleIn
1818
updateInternals();
1919
});
2020

21-
// TODOWASM: retry logic
22-
// TODOWASM: throttling logic
23-
// TODOWASM: load icu data
24-
// TODOWASM: invokeLibraryInitializers
25-
// TODOWASM: webCIL
21+
// WASM-TODO: retry logic
22+
// WASM-TODO: throttling logic
23+
// WASM-TODO: load icu data
24+
// WASM-TODO: invokeLibraryInitializers
25+
// WASM-TODO: webCIL
2626

2727
export async function createRuntime(downloadOnly: boolean, loadBootResource?: LoadBootResourceCallback): Promise<any> {
2828
const config = getConfig();

src/native/corehost/browserhost/sample/dotnet.boot.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Licensed to the .NET Foundation under one or more agreements.
22
// The .NET Foundation licenses this file to you under the MIT license.
33

4-
// TODOWASM: this is dummy configuration until WASM SDK for corehost
4+
// WASM-TODO: this is dummy configuration until WASM SDK for corehost
55

66
export const config = /*json-start*/{
77
"mainAssemblyName": "HelloWorld.dll",

src/native/libs/System.Native.Browser/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,11 @@ set(ROLLUP_OUTPUTS
4242
"${CLR_ARTIFACTS_OBJ_DIR}/native/browser-${CMAKE_BUILD_TYPE}-wasm/System.Runtime.InteropServices.JavaScript.Native/libSystem.Runtime.InteropServices.JavaScript.Native.js.map"
4343
)
4444
if(NOT PRODUCT_VERSION_JS)
45-
# TODOWASM get dotnet ProductVersion from MSBuild
45+
# WASM-TODO get dotnet ProductVersion from MSBuild
4646
set(PRODUCT_VERSION_JS "10.0.0-dev")
4747
endif()
4848
if(NOT CI_BUILD_JS)
49-
# TODOWASM get ContinuousIntegrationBuild from MSBuild
49+
# WASM-TODO get ContinuousIntegrationBuild from MSBuild
5050
set(CI_BUILD_JS "false")
5151
endif()
5252

0 commit comments

Comments
 (0)