[release/7.0] System.Console: allow terminfo files to be larger than 4KiB. (#82082)

github-actions[bot] · tmds · web-flow · commit a03dfadaaaa8 · 2023-03-08T12:09:02.000-06:00
* System.Console: allow terminfo files to be larger than 4KiB.

* Remove file size check.

---------

Co-authored-by: Tom Deseyn &lt;tom.deseyn@gmail.com&gt;
diff --git a/src/libraries/System.Console/src/System/TermInfo.DatabaseFactory.cs b/src/libraries/System.Console/src/System/TermInfo.DatabaseFactory.cs
@@ -107,9 +107,8 @@ private static bool TryOpen(string filePath, [NotNullWhen(true)] out SafeFileHan
             {
                 // Read in all of the terminfo data
                 long termInfoLength = RandomAccess.GetLength(fd);
-                const int MaxTermInfoLength = 4096; // according to the term and tic man pages, 4096 is the terminfo file size max
                 const int HeaderLength = 12;
-                if (termInfoLength <= HeaderLength || termInfoLength > MaxTermInfoLength)
+                if (termInfoLength <= HeaderLength)
                 {
                     throw new InvalidOperationException(SR.IO_TermInfoInvalid);
                 }

Original file line number	Diff line number	Diff line change
`@@ -107,9 +107,8 @@ private static bool TryOpen(string filePath, [NotNullWhen(true)] out SafeFileHan`
`107`	`107`	`{`
`108`	`108`	`// Read in all of the terminfo data`
`109`	`109`	`long termInfoLength = RandomAccess.GetLength(fd);`
`110`		`- const int MaxTermInfoLength = 4096; // according to the term and tic man pages, 4096 is the terminfo file size max`
`111`	`110`	`const int HeaderLength = 12;`
`112`		`- if (termInfoLength <= HeaderLength \|\| termInfoLength > MaxTermInfoLength)`
	`111`	`+ if (termInfoLength <= HeaderLength)`
`113`	`112`	`{`
`114`	`113`	`throw new InvalidOperationException(SR.IO_TermInfoInvalid);`
`115`	`114`	`}`