Add missing overrides for IsCollectible (#115785)

* Add missing overrides for IsCollectible
* Add basic IsCollectible test cases for all reflection types

Co-authored-by: Jan Kotas <[email protected]>

Author: Venkad000

src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeConstructorInfo.CoreCLR.cs

@@ -173,6 +173,7 @@ public override IList<CustomAttributeData> GetCustomAttributesData()
         internal RuntimeType GetRuntimeType() { return m_declaringType; }
         internal RuntimeModule GetRuntimeModule() { return RuntimeTypeHandle.GetModule(m_declaringType); }
         internal RuntimeAssembly GetRuntimeAssembly() { return GetRuntimeModule().GetRuntimeAssembly(); }
+        public override bool IsCollectible => m_declaringType.IsCollectible;
         #endregion
 
         #region MethodBase Overrides

src/coreclr/System.Private.CoreLib/src/System/Reflection/RuntimeEventInfo.cs

@@ -129,6 +129,7 @@ public override IList<CustomAttributeData> GetCustomAttributesData()
         public override int MetadataToken => m_token;
         public override Module Module => GetRuntimeModule();
         internal RuntimeModule GetRuntimeModule() { return m_declaringType.GetRuntimeModule(); }
+        public override bool IsCollectible => m_declaringType.IsCollectible;
         #endregion
 
         #region EventInfo Overrides

src/coreclr/nativeaot/System.Private.CoreLib/src/System/Reflection/Runtime/General/ThunkedApis.cs

@@ -95,6 +95,8 @@ internal abstract partial class RuntimeConstructorInfo
         public sealed override bool IsSecurityCritical => true;
         public sealed override bool IsSecuritySafeCritical => false;
         public sealed override bool IsSecurityTransparent => false;
+
+        public sealed override bool IsCollectible => false;
     }
 }
 
@@ -105,6 +107,8 @@ internal abstract partial class RuntimeEventInfo
         public sealed override MethodInfo GetAddMethod(bool nonPublic) => AddMethod.FilterAccessor(nonPublic);
         public sealed override MethodInfo GetRemoveMethod(bool nonPublic) => RemoveMethod.FilterAccessor(nonPublic);
         public sealed override MethodInfo GetRaiseMethod(bool nonPublic) => RaiseMethod?.FilterAccessor(nonPublic);
+
+        public sealed override bool IsCollectible => false;
     }
 }
 
@@ -119,6 +123,16 @@ internal abstract partial class RuntimeMethodInfo
         public sealed override bool IsSecurityCritical => true;
         public sealed override bool IsSecuritySafeCritical => false;
         public sealed override bool IsSecurityTransparent => false;
+
+        public sealed override bool IsCollectible => false;
+    }
+}
+
+namespace System.Reflection.Runtime.FieldInfos
+{
+    internal abstract partial class RuntimeFieldInfo
+    {
+        public sealed override bool IsCollectible => false;
     }
 }
 
@@ -145,6 +159,8 @@ public sealed override MethodInfo[] GetAccessors(bool nonPublic)
                 accessors[index++] = setter;
             return accessors;
         }
+
+        public sealed override bool IsCollectible => false;
     }
 }
 

src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/IsCollectibleTests.cs

@@ -17,6 +17,40 @@ public TestAssemblyLoadContext() : base(true) {}
         protected override Assembly Load(AssemblyName assemblyName) => null;
     }
 
+    public class BasicIsCollectibleTests
+    {
+        [Fact]
+        public void CoreLib_IsCollectibleFalse()
+        {
+            Assert.False(typeof(object).IsCollectible);
+            Assert.False(typeof(Console).Assembly.IsCollectible);
+            Assert.False(typeof(Math).Assembly.IsCollectible);
+            Assert.False(typeof(string).Assembly.IsCollectible);
+            Assert.False(typeof(List<>).Assembly.IsCollectible);
+            Assert.False(typeof(object).Assembly.IsCollectible);
+            Assert.False(typeof(IDisposable).Assembly.IsCollectible);
+            Assert.False(typeof(Span<>).Assembly.IsCollectible);
+            Assert.False(typeof(Enumerable).Assembly.IsCollectible);
+            Assert.False(typeof(string).GetMethods().First(m => m.Name == "Substring" && m.GetParameters().Length == 1).IsCollectible);
+            Assert.False(typeof(Dictionary<,>).Assembly.IsCollectible);
+            Assert.False(typeof(object).GetMethod("ToString").IsCollectible);
+            Assert.False(typeof(string).GetMethod("Contains", new[] { typeof(string) }).IsCollectible);
+            Assert.False(typeof(IntPtr).GetField("Zero").IsCollectible);
+            Assert.False(typeof(IntPtr).GetProperty("MaxValue").IsCollectible);
+            Assert.False(typeof(IntPtr).GetProperty("MinValue").IsCollectible);
+            Assert.False(typeof(DateTime).GetProperty("Now").IsCollectible);
+            Assert.False(typeof(AppDomain).GetMethod("GetData").IsCollectible);
+            Assert.False(typeof(AppDomain).GetMethod("ToString").IsCollectible);
+            Assert.False(typeof(string).GetConstructor(new[] { typeof(char[]), typeof(int), typeof(int) })!.IsCollectible);
+            Assert.False(typeof(string).GetConstructor(new[] { typeof(char), typeof(int) })!.IsCollectible);
+            Assert.False(typeof(TimeSpan).GetConstructor(new[] { typeof(int), typeof(int), typeof(int) })!.IsCollectible);
+            Assert.False(typeof(Uri).GetConstructor(new[] { typeof(string) })!.IsCollectible);
+            Assert.False(typeof(AppDomain).GetEvent("AssemblyLoad")!.IsCollectible);
+            Assert.False(typeof(AppDomain).GetEvent("ProcessExit")!.IsCollectible);
+
+       }
+    }
+
     [ActiveIssue("https://github.com/mono/mono/issues/15142", TestRuntimes.Mono)]
     public class IsCollectibleTests
     {

src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeEventInfo.cs

@@ -87,6 +87,8 @@ internal RuntimeModule GetRuntimeModule()
             return GetDeclaringTypeInternal().GetRuntimeModule();
         }
 
+        public override bool IsCollectible => false;
+
         internal BindingFlags GetBindingFlags()
         {
             MonoEventInfo info = GetEventInfo(this);

src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeFieldInfo.cs

@@ -69,6 +69,8 @@ internal RuntimeModule GetRuntimeModule()
             return GetDeclaringTypeInternal().GetRuntimeModule();
         }
 
+        public override bool IsCollectible => false;
+
         [MethodImplAttribute(MethodImplOptions.InternalCall)]
         internal extern override object UnsafeGetValue(object obj);
 

src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.Mono.cs

@@ -181,6 +181,8 @@ public override Module Module
             }
         }
 
+        public override bool IsCollectible => false;
+
         private string FormatNameAndSig()
         {
             // Serialization uses ToString to resolve MethodInfo overloads.
@@ -747,6 +749,8 @@ public override Module Module
             }
         }
 
+        public override bool IsCollectible => false;
+
         internal RuntimeModule GetRuntimeModule()
         {
             return RuntimeTypeHandle.GetModule((RuntimeType)DeclaringType);

src/mono/System.Private.CoreLib/src/System/Reflection/RuntimePropertyInfo.cs

@@ -136,6 +136,8 @@ internal RuntimeModule GetRuntimeModule()
             return GetDeclaringTypeInternal().GetRuntimeModule();
         }
 
+        public override bool IsCollectible => false;
+
         #region Object Overrides
         public override string ToString()
         {

src/mono/System.Private.CoreLib/src/System/RuntimeType.Mono.cs

@@ -1327,6 +1327,8 @@ protected override bool IsValueTypeImpl()
         // Returns true for generic parameters with the Enum constraint.
         public override bool IsEnum => GetBaseType() == EnumType;
 
+        public override bool IsCollectible => false;
+
         // Returns true for actual enum types only, ignoring generic parameter constraints.
         internal bool IsActualEnum
         {