Skip to content

Commit 51bd2b9

Browse files
github-actions[bot]ilonatommylewing
authored
[wasm] Bump chrome for testing - linux: 128.0.6613.119, windows: 128.0.6613.120 (#107504)
* Automated bump of chrome version * Addning new `BrowserArguments` is possible without changes on xharness side. * Add `--disable-gpu` to lib tests as well. * Set `PageLoadStrategy=NONE` for browser on Windows to avoid timeouts in driver-browser communication. * Remove whitespace. * Set the fixing flag for lib tests on Windows. * Fix: add args to chrome scenario, not node. * Move appended WBT args to one place. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ilona Tomkowicz <[email protected]> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Ilona Tomkowicz <[email protected]>
1 parent e8613a6 commit 51bd2b9

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

eng/testing/BrowserVersions.props

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<Project>
22
<PropertyGroup>
3-
<linux_ChromeVersion>126.0.6478.114</linux_ChromeVersion>
4-
<linux_ChromeRevision>1300313</linux_ChromeRevision>
5-
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1300316</linux_ChromeBaseSnapshotUrl>
6-
<linux_V8Version>12.6.228</linux_V8Version>
7-
<win_ChromeVersion>126.0.6478.36</win_ChromeVersion>
8-
<win_ChromeRevision>1300313</win_ChromeRevision>
9-
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1300320</win_ChromeBaseSnapshotUrl>
10-
<win_V8Version>12.6.228</win_V8Version>
3+
<linux_ChromeVersion>128.0.6613.119</linux_ChromeVersion>
4+
<linux_ChromeRevision>1331488</linux_ChromeRevision>
5+
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1331503</linux_ChromeBaseSnapshotUrl>
6+
<linux_V8Version>12.8.374</linux_V8Version>
7+
<win_ChromeVersion>128.0.6613.120</win_ChromeVersion>
8+
<win_ChromeRevision>1331488</win_ChromeRevision>
9+
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1331504</win_ChromeBaseSnapshotUrl>
10+
<win_V8Version>12.8.374</win_V8Version>
1111
<linux_FirefoxRevision>125.0.1</linux_FirefoxRevision>
1212
<linux_GeckoDriverRevision>0.34.0</linux_GeckoDriverRevision>
1313
<win_FirefoxRevision>125.0.1</win_FirefoxRevision>

eng/testing/WasmRunnerTemplate.cmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ if /I [%XHARNESS_COMMAND%] == [test] (
6565
set "BROWSER_PATH=--browser-path^=%HELIX_CORRELATION_PAYLOAD%\chrome-win\chrome.exe"
6666
)
6767
if [%JS_ENGINE_ARGS%] == [] (
68-
set "JS_ENGINE_ARGS=--browser-arg^=--js-flags^=--stack-trace-limit^=1000"
68+
set "JS_ENGINE_ARGS=--browser-arg^=--js-flags^=--stack-trace-limit^=1000 --browser-arg^=--disable-gpu --pageLoadStrategy=none"
6969
)
7070
) else (
7171
if /I [%SCENARIO%] == [WasmTestOnFirefox] (

src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,8 @@ protected static string RunWithXHarness(string testCommand, string testLogPath,
271271
args.Append($" --output-directory={testLogPath}");
272272
args.Append($" --expected-exit-code={expectedAppExitCode}");
273273
args.Append($" {extraXHarnessArgs ?? string.Empty}");
274+
args.Append(" --browser-arg=--disable-gpu");
275+
args.Append(" --pageLoadStrategy=none");
274276

275277
// `/.dockerenv` - is to check if this is running in a codespace
276278
if (File.Exists("/.dockerenv"))

0 commit comments

Comments
 (0)