Skip to content

Commit 2b1a794

Browse files
committed
[EventPipe] Fix folding constant warning
1 parent e256339 commit 2b1a794

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

src/native/eventpipe/ep-session.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -766,16 +766,15 @@ session_tracepoint_write_event (
766766

767767
// Setup iovec array
768768
const int max_non_parameter_iov = 9;
769-
const int max_static_io_capacity = 30; // Should account for most events that use EventData structs
770-
struct iovec static_io[max_static_io_capacity];
769+
struct iovec static_io[EP_USER_EVENTS_IOVEC_STACK_CAPACITY];
771770
struct iovec *io = static_io;
772771
ssize_t io_bytes_to_write = 0;
773772

774773
uint8_t *ep_event_data = ep_event_payload_get_data (ep_event_payload);
775774
uint32_t ep_event_data_len = ep_event_payload_get_event_data_len (ep_event_payload);
776775
int param_iov = ep_event_data != NULL ? 1 : ep_event_data_len;
777776
int io_elem_capacity = param_iov + max_non_parameter_iov;
778-
if (io_elem_capacity > max_static_io_capacity) {
777+
if (io_elem_capacity > EP_USER_EVENTS_IOVEC_STACK_CAPACITY) {
779778
io = (struct iovec *)malloc (sizeof (struct iovec) * io_elem_capacity);
780779
if (io == NULL)
781780
return false;
@@ -854,10 +853,9 @@ session_tracepoint_write_event (
854853
}
855854

856855
// Extension Activity IDs
857-
const int extension_activity_ids_max_len = 2 * (1 + EP_ACTIVITY_ID_SIZE);
858-
uint8_t extension_activity_ids[extension_activity_ids_max_len];
859-
uint16_t extension_activity_ids_len = construct_extension_activity_ids_buffer (extension_activity_ids, extension_activity_ids_max_len, activity_id, related_activity_id);
860-
EP_ASSERT (extension_activity_ids_len <= extension_activity_ids_max_len);
856+
uint8_t extension_activity_ids[EP_USER_EVENTS_ACTIVITY_ID_EXTENSION_MAX_SIZE];
857+
uint16_t extension_activity_ids_len = construct_extension_activity_ids_buffer (extension_activity_ids, EP_USER_EVENTS_ACTIVITY_ID_EXTENSION_MAX_SIZE, activity_id, related_activity_id);
858+
EP_ASSERT (extension_activity_ids_len <= EP_USER_EVENTS_ACTIVITY_ID_EXTENSION_MAX_SIZE);
861859
io[io_index].iov_base = extension_activity_ids;
862860
io[io_index].iov_len = extension_activity_ids_len;
863861
io_index++;

src/native/eventpipe/ep-types-forward.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,12 @@ typedef struct _StreamWriterVtable StreamWriterVtable;
6969

7070
#define EP_MAX_STACK_DEPTH 100
7171

72+
#define EP_USER_EVENTS_IOVEC_STACK_CAPACITY 30
73+
74+
// Maximum number of bytes needed to encode (ActivityId + RelatedActivityId),
75+
// each as (1 marker byte + 16 byte GUID).
76+
#define EP_USER_EVENTS_ACTIVITY_ID_EXTENSION_MAX_SIZE (2 * (1 + EP_ACTIVITY_ID_SIZE))
77+
7278
/*
7379
* EventPipe Enums.
7480
*/

0 commit comments

Comments
 (0)