CodeQL spillStack (#104376)

mikelle-rogers · web-flow · commit 13cf2649ad24 · 2024-07-08T17:32:58.000-07:00
diff --git a/src/coreclr/utilcode/ilformatter.cpp b/src/coreclr/utilcode/ilformatter.cpp
@@ -133,12 +133,12 @@ void ILFormatter::setTarget(size_t ilOffset, size_t depth) {
 /***************************************************************************/
 void ILFormatter::spillStack(OutString* out) {
 
-    for(unsigned i = 0; i < stackDepth(); i++) {
+    for(size_t i = 0; i < stackDepth(); i++) {
         // don't bother spilling something already spilled.
         if (memcmp(stackStart[i].val.val(), "@STK", 4) != 0)
-            *out << "@STK" << i << " = " << stackStart[i].val.val() << "\n";
+            *out << "@STK" << static_cast<unsigned int>(i) << " = " << stackStart[i].val.val() << "\n";
         stackStart[i].val.clear();
-        stackStart[i].val << "@STK" << i ;
+        stackStart[i].val << "@STK" << static_cast<unsigned int>(i);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -133,12 +133,12 @@ void ILFormatter::setTarget(size_t ilOffset, size_t depth) {`
`133`	`133`	`/***************************************************************************/`
`134`	`134`	`void ILFormatter::spillStack(OutString* out) {`
`135`	`135`
`136`		`- for(unsigned i = 0; i < stackDepth(); i++) {`
	`136`	`+ for(size_t i = 0; i < stackDepth(); i++) {`
`137`	`137`	`// don't bother spilling something already spilled.`
`138`	`138`	`if (memcmp(stackStart[i].val.val(), "@STK", 4) != 0)`
`139`		`- *out << "@STK" << i << " = " << stackStart[i].val.val() << "\n";`
	`139`	`+ *out << "@STK" << static_cast<unsigned int>(i) << " = " << stackStart[i].val.val() << "\n";`
`140`	`140`	`stackStart[i].val.clear();`
`141`		`- stackStart[i].val << "@STK" << i ;`
	`141`	`+ stackStart[i].val << "@STK" << static_cast<unsigned int>(i);`
`142`	`142`	`}`
`143`	`143`	`}`
`144`	`144`