[release/10.0] Move MLDsa Experimental to appropriate members (#119515)

github-actions[bot] · bartonjs · web-flow · commit 0338543a3bcf · 2025-09-10T11:16:34.000-07:00
* Move MLDsa Experimental to appropriate members

Not experimental:
* MLDsaAlgorithm (whole type)
* MLDsa (class name)
* MLDsa.GenerateKey
* MLDsa.ImportMLDsaPublicKey
* MLDsa.ImportMLDsaPrivateKey
* MLDsa.ImportMLDsaPrivateSeed
* MLDsa.ExportMLDsaPublicKey
* MLDsa.ExportMLDsaPrivateKey
* MLDsa.ExportMLDsaPrivateSeed
* MLDsa.SignData
* MLDsa.VerifyData
* Any *Core method for the above

Experimental:
* IETF Formats
  * MLDsa.ImportFromPem
  * MLDsa.ImportFromEncryptedPem
  * MLDsa.ImportPkcs8PrivateKey
  * MLDsa.ImportEncryptedPkcs8PrivateKey
  * MLDsa.ImportSubjectPublicKeyInfo
  * MLDsa.ExportPkcs8PrivateKey
  * MLDsa.ExportPkcs8PrivateKeyPem
  * MLDsa.ExportEncryptedPkcs8PrivateKey
  * MLDsa.ExportEncryptedPkcs8PrivateKeyPem
  * MLDsa.ExportSubjectPublicKeyInfo
  * MLDsa.ExportSubjectPublicKeyInfoPem
  * And any *Core methods powering them
* Unsure we have the right shape
  * MLDsa.SignPreHash
  * MLDsa.VerifyPreHash
  * MLDsa.SignMu
  * MLDsa.VerifyMu
  * And any *Core methods powering them

* Missed one

* Second ring

---------

Co-authored-by: Jeremy Barton &lt;jbarton@microsoft.com&gt;
diff --git a/src/libraries/Common/src/System/Security/Cryptography/MLDsa.cs b/src/libraries/Common/src/System/Security/Cryptography/MLDsa.cs
diff --git a/src/libraries/Common/src/System/Security/Cryptography/MLDsaAlgorithm.cs b/src/libraries/Common/src/System/Security/Cryptography/MLDsaAlgorithm.cs
@@ -10,7 +10,6 @@ namespace System.Security.Cryptography
     ///   Represents a specific algorithm within the ML-DSA family.
     /// </summary>
     [DebuggerDisplay("{Name,nq}")]
-    [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
     public sealed class MLDsaAlgorithm : IEquatable<MLDsaAlgorithm>
     {
         /// <summary>
diff --git a/src/libraries/Common/src/System/Security/Cryptography/MLDsaCng.cs b/src/libraries/Common/src/System/Security/Cryptography/MLDsaCng.cs
@@ -21,7 +21,6 @@ namespace System.Security.Cryptography
     ///     cryptographic libraries.
     ///   </para>
     /// </remarks>
-    [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
     public sealed partial class MLDsaCng : MLDsa
     {
         private CngKey _key;
diff --git a/src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs b/src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs
diff --git a/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithm.cs b/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithm.cs
@@ -205,7 +205,6 @@ public static CngAlgorithm Sha512
         ///   A new <see cref="CngAlgorithm"/> object that specifies the Module-Lattice-Based Digital Signature
         ///   Algorithm (ML-DSA).
         /// </value>
-        [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
         public static CngAlgorithm MLDsa => field ??= new CngAlgorithm("ML-DSA"); // BCRYPT_MLDSA_ALGORITHM
 
         /// <summary>
diff --git a/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithmGroup.cs b/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithmGroup.cs
@@ -133,7 +133,6 @@ public static CngAlgorithmGroup Rsa
         /// <value>
         ///   An object that specifies the ML-DSA family of algorithms.
         /// </value>
-        [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
         public static CngAlgorithmGroup MLDsa =>
             field ??= new CngAlgorithmGroup("MLDSA"); // NCRYPT_MLDSA_ALGORITHM_GROUP
 
diff --git a/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngKeyBlobFormat.cs b/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngKeyBlobFormat.cs
@@ -145,7 +145,6 @@ public static CngKeyBlobFormat GenericPublicBlob
         /// <remarks>
         ///   The value identified by this blob format is &quot;PQDSAPUBLICBLOB&quot;.
         /// </remarks>
-        [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
         public static CngKeyBlobFormat PQDsaPublicBlob =>
             field ??= new CngKeyBlobFormat("PQDSAPUBLICBLOB"); // BCRYPT_PQDSA_PUBLIC_BLOB
 
@@ -160,7 +159,6 @@ public static CngKeyBlobFormat GenericPublicBlob
         /// <remarks>
         ///   The value identified by this blob format is &quot;PQDSAPRIVATEBLOB&quot;.
         /// </remarks>
-        [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
         public static CngKeyBlobFormat PQDsaPrivateBlob =>
             field ??= new CngKeyBlobFormat("PQDSAPRIVATEBLOB"); // BCRYPT_PQDSA_PRIVATE_BLOB
 
@@ -175,7 +173,6 @@ public static CngKeyBlobFormat GenericPublicBlob
         /// <remarks>
         ///   The value identified by this blob format is &quot;PQDSAPRIVATESEEDBLOB&quot;.
         /// </remarks>
-        [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
         public static CngKeyBlobFormat PQDsaPrivateSeedBlob =>
             field ??= new CngKeyBlobFormat("PQDSAPRIVATESEEDBLOB"); // BCRYPT_PQDSA_PRIVATE_SEED_BLOB
 
diff --git a/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/MLDsaOpenSsl.cs b/src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/MLDsaOpenSsl.cs
@@ -20,7 +20,6 @@ namespace System.Security.Cryptography
     ///     cryptographic libraries.
     ///   </para>
     /// </remarks>
-    [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
     public sealed partial class MLDsaOpenSsl : MLDsa
     {
         private SafeEvpPKeyHandle _key;

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ namespace System.Security.Cryptography`
`10`	`10`	`/// Represents a specific algorithm within the ML-DSA family.`
`11`	`11`	`/// </summary>`
`12`	`12`	`[DebuggerDisplay("{Name,nq}")]`
`13`		`- [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]`
`14`	`13`	`public sealed class MLDsaAlgorithm : IEquatable<MLDsaAlgorithm>`
`15`	`14`	`{`
`16`	`15`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,6 @@ namespace System.Security.Cryptography`
`21`	`21`	`/// cryptographic libraries.`
`22`	`22`	`/// </para>`
`23`	`23`	`/// </remarks>`
`24`		`- [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]`
`25`	`24`	`public sealed partial class MLDsaCng : MLDsa`
`26`	`25`	`{`
`27`	`26`	`private CngKey _key;`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ namespace System.Security.Cryptography`
`20`	`20`	`/// cryptographic libraries.`
`21`	`21`	`/// </para>`
`22`	`22`	`/// </remarks>`
`23`		`- [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]`
`24`	`23`	`public sealed partial class MLDsaOpenSsl : MLDsa`
`25`	`24`	`{`
`26`	`25`	`private SafeEvpPKeyHandle _key;`