[AD0001] Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeFor*InjectionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.

[MaceWindu]

Analyzer

Diagnostic ID: CA30xx

Analyzer source

NuGet Package: Microsoft.CodeAnalysis.NetAnalyzers

Version: 8.0.0-preview.23420.2

Describe the bug

RC1 analyzers release produce multiple Collection was modified; enumeration operation may not execute in different analyzers

Steps To Reproduce

No idea how to debug AD0001. At least stack trace in error message will help a lot.

Expected behavior

Works

Actual behavior

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForCommandExecutionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'.

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForDllInjectionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForFilePathInjectionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForOpenRedirectVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForRegexInjectionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForSqlInjectionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForXamlInjectionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForXmlInjectionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'

AD0001 Analyzer 'Microsoft.NetCore.Analyzers.Security.ReviewCodeForXPathInjectionVulnerabilities' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'

Additional context

[mavasani]

This was reported internally as well and the following exception stack trace was reported for the AD0001 diagnostic:

CSC : error AD0001: Analyzer 'Microsoft.CodeQuality.CSharp.Analyzers.Maintainability.CSharpAvoidDeadConditionalCode' threw an exception of type 'System.InvalidOperationException' with message 'Collection was modified; enumeration operation may not execute.'. [B:\dd\copilot-vs\src\Copilot\Copilot_0vdc5hkx_wpftmp.csproj]
  Exception occurred with following context: (TaskId:110)
  Compilation: GitHub.Copilot.VisualStudio (TaskId:110)
  ISymbol: SanitizeOpeningBraces (Method) (TaskId:110)
  System.InvalidOperationException: Collection was modified; enumeration operation may not execute. (TaskId:110)
  at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource) (TaskId:110)
  at System.Collections.Generic.Dictionary`2.KeyCollection.Enumerator.MoveNext() (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.AnalysisEntityBasedPredicateAnalysisData`1.ClearOverlappingAnalysisDataForIndexedEntity(AnalysisEntity analysisEntity, TValue value) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.AnalysisEntityBasedPredicateAnalysisData`1.ClearOverlappingAnalysisDataForIndexedEntity(AnalysisEntity analysisEntity, TValue value) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.ValueContentAnalysis.ValueContentAnalysis.ValueContentDataFlowOperationVisitor.SetAbstractValue(ValueContentAnalysisData analysisData, AnalysisEntity analysisEntity, ValueContentAbstractValue value, Boolean hasCompletePointsToAnalysisResult) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.ValueContentAnalysis.ValueContentAnalysis.ValueContentDataFlowOperationVisitor.SetAbstractValue(AnalysisEntity analysisEntity, ValueContentAbstractValue value) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.AnalysisEntityDataFlowOperationVisitor`4.SetAbstractValueForAssignment(AnalysisEntity targetAnalysisEntity, AnalysisEntity assignedValueEntity, IOperation assignedValueOperation, TAbstractAnalysisValue assignedValue) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.AnalysisEntityDataFlowOperationVisitor`4.SetAbstractValueForAssignment(AnalysisEntity targetAnalysisEntity, IOperation assignedValueOperation, TAbstractAnalysisValue assignedValue) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.AnalysisEntityDataFlowOperationVisitor`4.SetAbstractValueForAssignment(IOperation target, IOperation assignedValueOperation, TAbstractAnalysisValue assignedValue, Boolean mayBeAssignment) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowOperationVisitor`4.VisitAssignmentOperation(IAssignmentOperation operation, Object argument) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowOperationVisitor`4.VisitCore(IOperation operation, Object argument) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowOperationVisitor`4.Visit(IOperation operation, Object argument) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowOperationVisitor`4.VisitArray(IEnumerable`1 operations, Object argument) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.ValueContentAnalysis.ValueContentAnalysis.ValueContentDataFlowOperationVisitor.DefaultVisit(IOperation operation, Object argument) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowOperationVisitor`4.VisitCore(IOperation operation, Object argument) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowOperationVisitor`4.Visit(IOperation operation, Object argument) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowOperationVisitor`4.Flow(IOperation statement, BasicBlock block, TAnalysisData input) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowAnalysis`5.Flow(DataFlowOperationVisitor`4 operationVisitor, BasicBlock block, TAnalysisData data) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowAnalysis`5.RunCore(ControlFlowGraph cfg, PooledSortedSet`1 worklist, PooledSortedSet`1 pendingBlocksNeedingAtLeastOnePass, TAnalysisData initialAnalysisData, DataFlowAnalysisResultBuilder`1 resultBuilder, PooledHashSet`1 uniqueSuccessors, PooledDictionary`2 finallyBlockSuccessorsMap, PooledDictionary`2 catchBlockInputDataMap, PooledDictionary`2 inputDataFromInfeasibleBranchesMap, PooledDictionary`2 blockToUniqueInputFlowMap, PooledDictionary`2 loopRangeMap, Boolean exceptionPathsAnalysisPostPass) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.DataFlowAnalysis`5.Run(TAnalysisContext analysisContext) (TaskId:110)
  at Analyzer.Utilities.SingleThreadedConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory) (TaskId:110)
  at Microsoft.CodeAnalysis.FlowAnalysis.DataFlow.ValueContentAnalysis.ValueContentAnalysis.TryGetOrComputeResult(ControlFlowGraph cfg, ISymbol owningSymbol, AnalyzerOptions analyzerOptions, WellKnownTypeProvider wellKnownTypeProvider, PointsToAnalysisKind pointsToAnalysisKind, InterproceduralAnalysisConfiguration interproceduralAnalysisConfig, DataFlowAnalysisResult`2& copyAnalysisResult, PointsToAnalysisResult& pointsToAnalysisResult, Boolean pessimisticAnalysis, Boolean performCopyAnalysis, InterproceduralAnalysisPredicate interproceduralAnalysisPredicate, ImmutableArray`1 additionalSupportedValueTypes, Func`2 getValueContentValueForAdditionalSupportedValueTypeOperation) (TaskId:110)
  at Microsoft.CodeQuality.Analyzers.Maintainability.AvoidDeadConditionalCode.<Initialize>b__8_1(OperationBlockAnalysisContext operationBlockContext) (TaskId:110)
  at Microsoft.CodeAnalysis.Diagnostics.AnalyzerExecutor.<>c__54`1.<ExecuteBlockActions>b__54_1(ValueTuple`2 data) (TaskId:110)
  at Microsoft.CodeAnalysis.Diagnostics.AnalyzerExecutor.ExecuteAndCatchIfThrows_NoLock[TArg](DiagnosticAnalyzer analyzer, Action`1 analyze, TArg argument, Nullable`1 info, CancellationToken cancellationToken) (TaskId:110)
  ----- (TaskId:110)

[mavasani]

FYI @carlossanlop @buyaa-n @jeffhandley - this regression was introduced by me with 716272a. The exception is coming from the below loop:

roslyn-analyzers/src/Utilities/FlowAnalysis/FlowAnalysis/Framework/DataFlow/AnalysisEntityBasedPredicateAnalysisData.cs

Line 173 in d29b797

foreach (var entity in CoreAnalysisData.Keys)

I am going to investigate this today and hopefully soon have a PR for the fix targeting .NET 8 release branch. We would need to get this through the required approvals.

[carlossanlop]

Thanks for the heads up. The RC2 snap will happen on Monday September 18th EOD. Before the snap, the backport will only require M2 approval for merging. After the snap, it will require Tactics approval for merging.

[mavasani]

@MaceWindu Thank you for reporting this issue. I was able to get a fix for the issue merged into our main branch targeting .NET9 and we are also considering backporting this for .NET8 RC2.

I couldn’t create a minimal repro case for this exception diagnostic though. Can you please help us validate the fix on your repro by upgrading to this NuGet package: https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet9/NuGet/Microsoft.CodeAnalysis.NetAnalyzers/overview/9.0.0-preview.23463.3?